fix: DBTP-896 - invalid opensearch config #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuele-mattiuzzo
approved these changes
Apr 12, 2024
WillGibson
reviewed
Apr 12, 2024
JohnStainsby
commented
Apr 18, 2024
| @@ -44,7 +32,7 @@ run "test_create_opensearch" { | |||
| } | |||
|
|
|||
| assert { | |||
| condition = aws_opensearch_domain.this.cluster_config[0].dedicated_master_type == null | |||
| condition = aws_opensearch_domain.this.cluster_config[0].dedicated_master_type == "" | |||
There was a problem hiding this comment.
Even though it doesn't show in the terraform plan and it's an optional property dedicated_master_type gets deployed as an empty string
JohnStainsby
commented
Apr 18, 2024
| } | ||
|
|
||
| assert { | ||
| condition = aws_opensearch_domain.this.ebs_options[0].throughput == 0 |
There was a problem hiding this comment.
Similar to dedicated_master_type this property gets deployed as 0 rather than null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some OpenSearch properties conditional
availability_zone_countshould only be set ifzone_awareness_enabledis truethroughputis only a valid property for gp3 volumes