Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DBTP-1503 - Terraform codebase pipelines #276

Merged
merged 42 commits into from
Nov 26, 2024

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Nov 8, 2024

Terraform pipelines based on the platform-config.yml. Each pipeline has a codebuild job to create deploy manifests and deploy actions for each service. The deploy order is set by run groups in the config.

Example section from platform-config.yml:

codebase_pipelines:
  - name: test
    repository: uktrade/demodjango
    services:
      - run_group_1:
        - web
      - run_group_2:
        - api
        - celery-worker
        - celery-beat
    pipelines:
      - name: main
        branch: main
        environments:
          - name: dev

Created pipeline:

image

Addresses most of https://uktrade.atlassian.net/browse/DBTP-1503.
Manual release pipeline and prod trigger pipeline will be separate PRs.

@JohnStainsby JohnStainsby changed the base branch from main to DBTP-1502-terraform-image-build-codebuild-project November 8, 2024 17:07
Base automatically changed from DBTP-1502-terraform-image-build-codebuild-project to main November 12, 2024 16:00
@JohnStainsby JohnStainsby changed the title feat: DBTP-1503 - terraform codebase pipeline feat: DBTP-1503 - Terraform codebase pipelines Nov 13, 2024
@JohnStainsby JohnStainsby marked this pull request as ready for review November 13, 2024 13:17
@JohnStainsby JohnStainsby requested a review from a team November 13, 2024 13:17
Copy link
Contributor

@WillGibson WillGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first pass. Brain is a bit too Friday afternoon for this many lines!

Have you been pairing on this? I'm wondering how deep I need to get into it to review it.

codebase-pipelines/artifactstore.tf Outdated Show resolved Hide resolved
codebase-pipelines/artifactstore.tf Show resolved Hide resolved
codebase-pipelines/artifactstore.tf Outdated Show resolved Hide resolved
codebase-pipelines/buildspec-manifests.yml Outdated Show resolved Hide resolved
codebase-pipelines/codebuild.tf Outdated Show resolved Hide resolved
codebase-pipelines/codebuild.tf Outdated Show resolved Hide resolved
codebase-pipelines/artifactstore.tf Show resolved Hide resolved
@JohnStainsby
Copy link
Contributor Author

JohnStainsby commented Nov 15, 2024

@WillGibson

A first pass. Brain is a bit too Friday afternoon for this many lines!

Have you been pairing on this? I'm wondering how deep I need to get into it to review it.

Yes, @james-francis-MT and I have been pairing on most of this. We've split some of it off into different PRs, but yeah it's big

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3937e53) to head (08d03a6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           50        50           
=========================================
  Hits            50        50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ejayesh ejayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terraform code lgtm, looking forward to this going in.

@JohnStainsby JohnStainsby merged commit 96b5935 into main Nov 26, 2024
48 checks passed
@JohnStainsby JohnStainsby deleted the DBTP-1503-terraform-codebase-pipeline branch November 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants