Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing load balancer permission #256

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: Add missing load balancer permission #256

merged 1 commit into from
Oct 25, 2024

Conversation

JohnStainsby
Copy link
Contributor

Add missing load balancer permission to the environment pipelines

@JohnStainsby JohnStainsby requested a review from a team October 25, 2024 14:21
ksugden
ksugden approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ksugden ksugden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update tests for this? Might not be covered anyway, since it's iam stuff.

@JohnStainsby
Copy link
Contributor Author

Do we need to update tests for this? Might not be covered anyway, since it's iam stuff.

@ksugden I had a look but none of the policy contents are covered

@JohnStainsby JohnStainsby merged commit 8c1357e into main Oct 25, 2024
10 checks passed
@JohnStainsby JohnStainsby deleted the environment-pipelines-missing-permission branch October 25, 2024 14:25
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksugden ksugden ksugden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnStainsby @ksugden