fix: DBTP-1435 Allow environment pipeline to update assume role policy on shared s3 role #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillGibson
reviewed
Oct 18, 2024
| "iam:UpdateAssumeRolePolicy" | ||
| ] | ||
| resources = [for environment in local.environment_config : "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/${var.application}-${environment.name}-shared-S3MigrationRole"] | ||
| } |
There was a problem hiding this comment.
Comes out like this for demodjango-main-environment-pipeline...
{
"Action": "iam:UpdateAssumeRolePolicy",
"Effect": "Allow",
"Resource": [
"arn:aws:iam::<aws_account_number>:role/demodjango-staging-shared-S3MigrationRole",
"arn:aws:iam::<aws_account_number>:role/demodjango-dev-shared-S3MigrationRole"
],
"Sid": "AllowUpdatingSharedS3MigrationRoleTrustPolicy"
}
There was a problem hiding this comment.
We haven't included tests for this at this stage for the reasons mentioned in a Slack thread I've just started in our channel.
chiaramapellimt
approved these changes
Oct 18, 2024
WillGibson
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue:DBTP-1435