Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBTP-1394 - Fix platform-helper environment generate command in environment pipeline apply stage #236

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Sep 25, 2024

The way the AWS profile was accessed in the platform-helper environment generate command changed in this PR

We now need a named AWS_PROFILE in the environment pipeline apply stage rather than using the inherited CodeBuild permissions.

@JohnStainsby JohnStainsby marked this pull request as ready for review September 25, 2024 15:40
@JohnStainsby JohnStainsby requested a review from a team September 25, 2024 15:42
Copy link
Contributor

@ejayesh ejayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Approved

@JohnStainsby JohnStainsby merged commit f0b7bc1 into main Sep 25, 2024
17 checks passed
@JohnStainsby JohnStainsby deleted the set-non-prod-aws-profile branch September 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants