fix: DBTP-1366 - Force environment pipeline to trigger on correct branch #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnStainsby
commented
Sep 16, 2024
| push { | ||
| branches { | ||
| includes = [ | ||
| var.trigger_on_push ? var.branch : "NO_TRIGGER" |
There was a problem hiding this comment.
Ideally here we would remove the trigger instead of setting a placeholder branch to prevent triggering var.trigger_on_push ? var.branch : "NO_TRIGGER", however Terraform doesn't detect the change if we omit the entire trigger block.
ksugden
reviewed
Sep 16, 2024
ksugden
reviewed
Sep 16, 2024
|
|
||
| assert { | ||
| condition = length(aws_codepipeline.environment_pipeline.trigger[0].git_configuration[0].push[0].branches[0].includes) == 1 | ||
| error_message = "Should be: true" |
There was a problem hiding this comment.
Suggested change
| error_message = "Should be: true" | |
| error_message = "Should be: 1" |
There was a problem hiding this comment.
The length function evaluates this to true|false but I've added a better message anyway
ksugden
reviewed
Sep 16, 2024
ksugden
reviewed
Sep 16, 2024
Co-authored-by: Kate Sugden <[email protected]>
Co-authored-by: Kate Sugden <[email protected]>
ksugden
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly add a trigger block with the source branch to the environment pipeline.