feat: Dbtp 946 vpc store nat egress ips in parameter store #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-griffin
changed the title
WillGibson
reviewed
Jun 6, 2024
| ### Test aws_security_group resource ### | ||
| assert { | ||
| condition = startswith(aws_security_group.vpc-core-sg.arn, "arn:aws:ec2:eu-west-2:852676506468:security-group/sg-") == true | ||
| condition = length(regexall("|(arn:aws:ec2:eu-west-2:)[0-9]{12,14}(:security-group/sg-)|", aws_security_group.vpc-core-sg.arn)) > 0 |
There was a problem hiding this comment.
The hard coded account number was causing this test to fail.
tony-griffin
commented
Jun 6, 2024
| # checkov:skip=CKV_AWS_337:Ensure SSM parameters are using KMS CMK. Related ticket: https://uktrade.atlassian.net/browse/DBTP-946 | ||
| # checkov:skip=CKV2_AWS_34:AWS SSM Parameter should be Encrypted. Related ticket: https://uktrade.atlassian.net/browse/DBTP-946 | ||
| for_each = toset(var.arg_config.nat_gateways) | ||
| name = "/${var.arg_name}/nat-eip-${each.key}/ADDITIONAL_IP_LIST" |
There was a problem hiding this comment.
@ejayesh in the ticket (https://uktrade.atlassian.net/jira/software/c/projects/DBTP/boards/458?quickFilter=882&selectedIssue=DBTP-946) it says to call it /ADDITIONAL_IP_LIST, but also in the ticket it says that we are not to add the parameter to a list.
Any clarification around this please?
Co-authored-by: Will Gibson <[email protected]>
samuele-mattiuzzo
approved these changes
Jun 6, 2024
tony-griffin
deleted the
dbtp-946-vpc-store-NAT-egress-ips-in-parameter-store
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBTP-946 VPC module - store NAT egress IPs in parameter store
Creates an SSM parameter for each VPC that contains a NAT gateway egress EIP public IP address.
VALUE: This can then be passed into the IP filter when it needs to allow internal traffic
Currently skipping 2 Checkov alerts, discussion to be had as to whether these need a KMS key & SecureString type:
SSM params:
