feat!: dbtp 928 add cdn endpoint module #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejayesh
changed the title
WillGibson
reviewed
May 30, 2024
|
Title should start Pull request description should include Upgrade Path, for easy copying into the release notes. |
ejayesh
changed the title
WillGibson
reviewed
May 30, 2024
gabelton
reviewed
May 30, 2024
gabelton
reviewed
May 30, 2024
gabelton
reviewed
May 30, 2024
Co-authored-by: Will Gibson <[email protected]> Co-authored-by: Gabe Naughton <[email protected]>
lgarvey
approved these changes
May 31, 2024
I updated the readme and updated the platform docs |
WillGibson
reviewed
May 31, 2024
…orm-modules into DBTP-928-add-cdn
gabelton
approved these changes
May 31, 2024
WillGibson
approved these changes
May 31, 2024
There was a problem hiding this comment.
For the bits I can meaningfully grok, mostly the documentation stuff, I'm adding my approval to @lgarvey's for the Terraform parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new module called CDN, this will enable the deployment of a CloudFront endpoint.
There are breaking changes in extensions.yml to facilitate this change.
Upgrade path: in extensions.yml update type: alb "cdn_domains_list" variable to include applications internal prefix. See README.md/CDN for example.