fix: DBTP-1010 Readonly postgres user doesn't have read perms #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuele-mattiuzzo
approved these changes
May 30, 2024
WillGibson
approved these changes
May 30, 2024
| @@ -119,11 +119,11 @@ resource "aws_lambda_invocation" "create-readonly-user" { | |||
| CopilotApplication = var.application | |||
| CopilotEnvironment = var.environment | |||
| MasterUserSecretArn = aws_db_instance.default.master_user_secret[0].secret_arn | |||
| SecretDescription = "RDS application user secret for ${local.name}" | |||
| SecretDescription = "RDS readonly user secret for ${local.name}" | |||
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lambda runs
ALTER DEFAULT PRIVILEGES FOR USER readonly_user IN SCHEMA public GRANT SELECT ON TABLES TO readonly_user;. This grants read permissions to the readonly user on future tables, but ONLY those created by the readonly_user. We're moving to use application_user to perform migrations, so the necessary command is nowALTER DEFAULT PRIVILEGES FOR USER application_user IN SCHEMA public GRANT SELECT ON TABLES TO readonly_user;