Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DBTP-914 - Environment pipeline terraform apply #116

Merged
merged 113 commits into from
May 15, 2024
Merged

feat: DBTP-914 - Environment pipeline terraform apply #116

merged 113 commits into from
May 15, 2024

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented May 7, 2024 •
edited
Loading

  • Run terraform apply in the pipeline
  • Optional approval stage if specified for the environment, where the terraform plan output can be reviewed

antroy-madetech and others added 30 commits April 18, 2024 10:27
@antroy-madetech
Initial role created with tests
04f785a
@antroy-madetech
Added tags to role
c0cb167
@antroy-madetech
Added s3 bucket for artifact store
3a76238
@antroy-madetech
Output test for s3 module
7b28fd3
@antroy-madetech
Working (dummy) codepipeline can now be created
a04a2d4
@antroy-madetech
Added requires KMS perms
a5764a1
@antroy-madetech
Codebuild failing but producing logs
349e9df
@antroy-madetech
Added S3 bucket perms to the codedeploy job
89f485e
@antroy-madetech
Restricted role permissions for logs to our log group
8c27004
@antroy-madetech
Renamed roles.tf -> iam.tf
9ebb2e4
@antroy-madetech
Codebuild 'install' job installs terraform, copilot, platform-helper
9d59f17
@antroy-madetech
Clean up
9a9af0a
@WillGibson
Remove Copilot string
be422d9
@WillGibson
Add repository variable and mock AWS provider
e803ee0
@WillGibson
Start poking at the tests, some progress, still failing
61aea48
@antroy-madetech
Overriding data block with minimal JSON
5bdacce
@antroy-madetech
Refactored tag tests
01c828e
@WillGibson
Merge branch 'main' into DBTP-911-Barebones-Pipeline
8c76626
@WillGibson
terraform fmt -recursive
9d001eb
@WillGibson
Add check on pipeline name and reuse the tags check
342eb00
@WillGibson
Add commented out annoying asertion
af74114
@WillGibson
Start adding assertions for aws_codepipeline.codepipeline.stage.action
31a36da
@WillGibson
Strip it down to should be
2b1cbcd
@WillGibson
Add assertions for artifact_store
f155607
@WillGibson
Rename stages etc.
4f09e60
@WillGibson
Test the pipeline tags
51a3b5b
@WillGibson
Rename stage back to build
9d7a146
@WillGibson
Remove test_create_pipeline_with_different_application
fe34a3b
@WillGibson
Little reshuffle
2913249
@antroy-madetech
Refactoring of names to bring in line with best practice guidelines
972599d
antroy-madetech and others added 17 commits May 3, 2024 15:09
@antroy-madetech
Tests for remaining stages
8ec504f
@JohnStainsby
Export build tools between pipeline stages
2053d6e
@JohnStainsby
Merge branch 'DBTP-914-pipeline-tf-apply' of github.com:uktrade/terra…
603962c 
…form-platform-modules into DBTP-914-pipeline-tf-apply
@JohnStainsby
Add codebuild projects for apply stage; Pass build outputs between st…
9159f2b 
…ages
@JohnStainsby
Pass terraform plan to approval stage
d658d4a
@JohnStainsby
Rename codebuild project; Add tests for build stage; Fix tests for st…
d7699f0 
…ages
@JohnStainsby
Update IAM policies for terraform apply in pipeline
0df7f50
@JohnStainsby
Merge branch 'main' into DBTP-914-pipeline-tf-apply
625ab68
@JohnStainsby
Increase codebuild timeout for apply stage
7ae629c
@JohnStainsby
Add central log arn
43d4a9f
@JohnStainsby
Add IAM permissions for terraform apply
3f279dd
@JohnStainsby
Fix pipeline name
e9d343f
@JohnStainsby
More IAM policies; Combine some policies for character limits
10d4c1f
@JohnStainsby
Add additional IAM policy tests; Formatting;
9bfde37
@JohnStainsby
More permissions
809d32a
@JohnStainsby
Merge branch 'main' into DBTP-914-pipeline-tf-apply
d874752
@JohnStainsby
Ensure lambda zip file is created during apply phase
4fdbebe
@JohnStainsby JohnStainsby marked this pull request as ready for review May 10, 2024 15:48
ejayesh
ejayesh approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ejayesh ejayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antroy-madetech antroy-madetech merged commit a7f701c into main May 15, 2024
5 of 6 checks passed
@antroy-madetech antroy-madetech deleted the DBTP-914-pipeline-tf-apply branch May 15, 2024 13:54
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejayesh ejayesh ejayesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnStainsby @ejayesh @antroy-madetech @WillGibson