Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DBTP-913 - Run terraform plan in environment pipelines #110

Merged
merged 77 commits into from
May 2, 2024
Merged

feat: DBTP-913 - Run terraform plan in environment pipelines #110

merged 77 commits into from
May 2, 2024

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented May 1, 2024 •
edited
Loading

  • Add permissions to CodeBuild role to allow Terraform access to the resources it needs
  • Run terraform init and terraform plan in the pipeline
  • Move domain provider into terraform-platform-modules/extensions/providers.tf

antroy-madetech and others added 30 commits April 18, 2024 10:27
@antroy-madetech
Initial role created with tests
04f785a
@antroy-madetech
Added tags to role
c0cb167
@antroy-madetech
Added s3 bucket for artifact store
3a76238
@antroy-madetech
Output test for s3 module
7b28fd3
@antroy-madetech
Working (dummy) codepipeline can now be created
a04a2d4
@antroy-madetech
Added requires KMS perms
a5764a1
@antroy-madetech
Codebuild failing but producing logs
349e9df
@antroy-madetech
Added S3 bucket perms to the codedeploy job
89f485e
@antroy-madetech
Restricted role permissions for logs to our log group
8c27004
@antroy-madetech
Renamed roles.tf -> iam.tf
9ebb2e4
@antroy-madetech
Codebuild 'install' job installs terraform, copilot, platform-helper
9d59f17
@antroy-madetech
Clean up
9a9af0a
@WillGibson
Remove Copilot string
be422d9
@WillGibson
Add repository variable and mock AWS provider
e803ee0
@WillGibson
Start poking at the tests, some progress, still failing
61aea48
@antroy-madetech
Overriding data block with minimal JSON
5bdacce
@antroy-madetech
Refactored tag tests
01c828e
@WillGibson
Merge branch 'main' into DBTP-911-Barebones-Pipeline
8c76626
@WillGibson
terraform fmt -recursive
9d001eb
@WillGibson
Add check on pipeline name and reuse the tags check
342eb00
@WillGibson
Add commented out annoying asertion
af74114
@WillGibson
Start adding assertions for aws_codepipeline.codepipeline.stage.action
31a36da
@WillGibson
Strip it down to should be
2b1cbcd
@WillGibson
Add assertions for artifact_store
f155607
@WillGibson
Rename stages etc.
4f09e60
@WillGibson
Test the pipeline tags
51a3b5b
@WillGibson
Rename stage back to build
9d7a146
@WillGibson
Remove test_create_pipeline_with_different_application
fe34a3b
@WillGibson
Little reshuffle
2913249
@antroy-madetech
Refactoring of names to bring in line with best practice guidelines
972599d
antroy-madetech and others added 21 commits April 29, 2024 14:07
@antroy-madetech
Bit of renaming
c70aa6d
@antroy-madetech
Added dependency for codepipeline on the codestar role
ce0adc6
@antroy-madetech
Added perms to read vpcs and subnets
788b4a1
@antroy-madetech
Final few perms to get redis working
7f6e2a8
@antroy-madetech
SSM and further EC2 perms
5dadd5b
@JohnStainsby
Add DNS account assume role policy
64b5bb4
@JohnStainsby
Add domain alias to providers
e32d0c4
@JohnStainsby
Add env to hosted zone name
cbf35ee
@JohnStainsby
Revert route53 name change
1d33730
@JohnStainsby
Remove env name
45c16d4
@JohnStainsby
Remove module source; Add variable for dns account it
cee1ca4
@JohnStainsby
Read properties from pipelines.yml variable
b4b9e06
@JohnStainsby
Remove dns variable; Fix iam issue
a7f2963
@JohnStainsby
Fix existing tests
4ef60b5
@JohnStainsby
Add codepipeline tests
61ad11f
@JohnStainsby
Fix IAM role names for consistency; Add additional IAM tests
e7f9846
@JohnStainsby
Fix formatting
71e5dac
@JohnStainsby
Merge branch 'main' into DBTP-913-Pipleline-tf-plan
fbef95e
@JohnStainsby
Fix terraform fmt issues
215cfcd
@JohnStainsby
Update example for CodeBuild tests
39b9029
@JohnStainsby
Split policy statements for ec2 read access
0722cfe
@JohnStainsby JohnStainsby marked this pull request as ready for review May 2, 2024 08:34
@JohnStainsby JohnStainsby requested a review from a team May 2, 2024 08:34
gabelton
gabelton reviewed May 2, 2024
View reviewed changes
environment-pipelines/buildspec.yml
@@ -35,7 +35,11 @@ phases:

build:
commands:
- echo "Build Phase"
- echo "Terraform Plan Phase"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these commands fall under the pre_build phase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes probably once the rest of the copilot and platform-helper commands are added. This stuff is most likely going to be moved to a separate buildspec file anyway to work with a plan -> manual approve -> apply process

@JohnStainsby JohnStainsby merged commit a66f04a into main May 2, 2024
6 checks passed
@JohnStainsby JohnStainsby deleted the DBTP-913-Pipleline-tf-plan branch May 2, 2024 15:48
@github-actions github-actions bot mentioned this pull request May 2, 2024
Merged
@github-actions github-actions bot mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabelton gabelton gabelton left review comments

@antroy-madetech antroy-madetech antroy-madetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnStainsby @gabelton @antroy-madetech @WillGibson