Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DBTP-839 Add tags for monitoring resources #102

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

WillGibson
Copy link
Contributor

Highlighted by use of tflint whilst adding pre-commit hooks.

@WillGibson WillGibson requested a review from a team April 26, 2024 16:37

assert {
condition = jsonencode(aws_resourcegroups_group.application-insights-resources.tags) == jsonencode(var.expected_tags)
error_message = "Expected: ${jsonencode(var.expected_tags)}\nActual: ${jsonencode(aws_resourcegroups_group.application-insights-resources.tags)}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines up so you can spot the difference easily.

Copy link
Contributor

@samuele-mattiuzzo samuele-mattiuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a title fix, chore I guess

@WillGibson WillGibson changed the title DBTP-839 Add tags for monitoring resources fix: DBTP-839 Add tags for monitoring resources Apr 29, 2024
@WillGibson WillGibson merged commit 5f56af5 into main Apr 29, 2024
5 of 6 checks passed
@WillGibson WillGibson deleted the DBTP-839-monitoring-tags-and-fix-lint-woes branch April 29, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants