Maintainer

[danner26]

Is your feature request related to a problem? Please describe.

Hello, the discussions are not fully setup otherwise I would submit there. I am one of the maintainers on the NetBox project. If you would like to chat about how I can assist with this repo I would be happy to help

Describe alternatives you've considered

N/A

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Are you willing to resolve this issue by submitting a Pull Request?

• Yes, I have the time, and I know how to start.
• Yes, I have the time, but I don't know how to start. I would need guidance.
• No, I don't have the time, although I believe I could do it if I had the time...
• No, I don't have the time and I wouldn't even know how to start.

[bdraco]

The two most pressing issues are:

home-assistant/core#117100
home-assistant/core#117274

There are a few others as well: https://github.com/home-assistant/core/issues?q=is%3Aopen+label%3A%22integration%3A+unifiprotect%22+sort%3Aupdated-desc

[bdraco]

I also opened discussions.
Thanks for volunteering 👍

[terrywood02]

Thanks for jumping in @danner26!!

[bdraco]

https://github.com/uilibs/uiprotect/releases/tag/v0.3.10 should take care of home-assistant/core#117274

[jasperslits]

I can reuse the commit for Unifi OS 4 token support https://github.com/AngellusMortis/pyunifiprotect/pull/388/commits to get home-assistant/core#117100 to work.

It has since been rewritten to use an API call to determine v3 vs v4, but my commits avoid a license discussion and accomplished the same.

Happy to change it but wondering if these commits would be a good basis.

[bdraco]

I can reuse the commit for Unifi OS 4 token support AngellusMortis/pyunifiprotect#388 (commits) to get home-assistant/core#117100 to work.

It has since been rewritten to use an API call to determine v3 vs v4, but my commits avoid a license discussion and accomplished the same.

Happy to change it but wondering if these commits would be a good basis.

If you could open up a PR with your commits it would be great as it avoid a license problem since you have the rights to contribute it. We can always refactor it in a followup PR.

[jasperslits]

I created PR #14 . Will try to make some time in the next days to do more testing between all other work / home chores.

[bdraco]

confirmed it didn't break unifi protect 3.x

It would be great to get some followup test coverge, but its good enough to merge for now.
Thanks!

[jasperslits]

Do you also have a Unifi OS 4.x console running to test on?

[bdraco]

I don't have anything upgraded to 4.x yet. I'll bump the lib in HA but leave the issue open until someone confirms its fixed

[bdraco]

I asked for someone to test it in home-assistant/core#117100 (comment)

[cyberpower678]

I have a vested interest in this library too, as I rely on it to backup my security events, and while I'm still going open pull requests to the original library, I wouldn't mind helping out. I have EA on every UI Protect device, so am able to test early to ensure the library continues to work. I actually have some code changes I would like to push right now regarding the get_camera_video. I'm throwing in my hat to help maintain the project.

[bdraco]

Thanks! Feel free to jump in and open a PR 👍

I know it probably goes without saying, but please sure not to copy any code from pyunifiprotect from after the license change that you don't already have the rights to as we don't want non-free code in this library.

[ronytomen]

Appears the original pyunifiprotect repository is no more.

[ep1cman]

@bdraco I appreciate your work getting this up and running and cleaning up the state of the repo.

I don't have enough spare time to become a main maintainer for this, but I am happy to help out with code reviews etc. I hope collaborating will be much easier now with a certain someone gone. As the developer of https://github.com/ep1cman/unifi-protect-backup, I highly relied on pyunifiprotect, and now this repo and am somewhat familiar with its workings. I stand on the shoulders of giants and am happy to help where I can, but unfortunately life is too hectic at the moment for me to be able to fully keep up with Ubiquiti and the usecases for HA outside of what is needed for my project.

[bdraco]

and am happy to help where I can

Any help is appreciated. If you don't have the time now, maybe in the future you can help more. In the meantime, help with issue triage and tips when another contributor is stuck on changes UI has made, can go a long way. Thanks!