Reformatted api_forms files #54

Daniel-Ibarrola · 2022-06-24T18:30:28Z

Description

Added a new function that creates a form attributes dictionary which now all files in api_forms call, using less code.
All these files were reformated to use spacing according to the style guide.

Todos

Removed some duplicate code
Reformated some functions

…e changes

… and get.py of that function.

…ibute.py

…oryDict

…tionary to reduce redundant code

…the file spacing

… from which all other errors inherit.

…to main

…duplication. Added docstrings

dprada

I am super excited, it is clear that your contribution to MolSysMT is going to have a great impact.

Anyway, it was a long review. Give me time to give it a second look.
In the meantime, please read my comments and reply to them -if you want-.

.gitignore

Untitled.ipynb

molsysmt/_private/digestion/argument.py

molsysmt/_private/digestion/box.py

molsysmt/tests/exceptions/test_not_implemeted_error.py

molsysmt/tests/exceptions/test_value_errors.py

molsysmt/tests/pbc/unwrap/test_unwrap_molsysmt_TrajectoryDict.py

molsysmt/tests/pbc/wrap_to_pbc/test_wrap_to_pbc_molsysmt_TrajectoryDict.py

sandbox/RMSD_test_pentah5.ipynb

dprada

All comments and suggestions to be revisited were reported already as new issues.

Daniel-Ibarrola and others added 16 commits June 20, 2022 14:19

Fixed wrong argument in get function in pbc tests.

9dffb0b

pycharm folders added to gitignore.

09d1d74

digest_element function modified to make it more readable. Minor styl…

0f558ad

…e changes

Changes to digestion functions.

c52169f

Removed try except clauses from get.py. diget_indices uses isinstance

261d3c7

Removed duplicate code in digest indices functions.

97e7b38

Moved digest_argument to a new file and removed duplication in set.py…

b078753

… and get.py of that function.

Removed try-excepts from set.py

28a6784

Removed item/has_attribute.py. Function is repeated in basic/has_attr…

d6ae4a6

…ibute.py

Temporarily disabled the tests unwrap_trajectoryDict and wrap_traject…

628b037

…oryDict

Removed unused function and classes in _private folder.

4fcb965

Added new TODOs

36899eb

Created a function that returns a template of the form_attributes dic…

eaa4dd6

…tionary to reduce redundant code

All api_forms files now use the form_attributes function. Reformated …

a3783f1

…the file spacing

Final touches to formatting

f50983c

Merge branch 'uibcdf:main' into main

31b12cb

Daniel-Ibarrola requested a review from dprada June 24, 2022 18:30

Daniel-Ibarrola added 7 commits June 24, 2022 18:24

Created a class for value errors and another for not implmented error…

08e269b

… from which all other errors inherit.

Merge branch 'main' of https://github.com/Daniel-Ibarrola/MolSysMT in…

71ebf7a

…to main

Removed duplicate code in group_indices.py

0c5a937

Moved all digest indices functions to a single file.

87dc673

Merged digest box lenghts and angles into a single function to avoid …

c5935b4

…duplication. Added docstrings

Tests for digest box.

2e1fef3

Docstrings, formatting and tests for digestion functions

e6e9a04

dprada reviewed Jun 26, 2022

View reviewed changes

dprada mentioned this pull request Jun 28, 2022

Function to convert mmtf files to mdtraj needs to be reviewed. #65

Open

dprada self-requested a review June 28, 2022 20:38

dprada approved these changes Jun 28, 2022

View reviewed changes

dprada merged commit 390976a into uibcdf:main Jun 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reformatted api_forms files #54

Reformatted api_forms files #54

Daniel-Ibarrola commented Jun 24, 2022

dprada left a comment

dprada left a comment

Reformatted api_forms files #54

Reformatted api_forms files #54

Conversation

Daniel-Ibarrola commented Jun 24, 2022

Description

Todos

dprada left a comment

Choose a reason for hiding this comment

dprada left a comment

Choose a reason for hiding this comment