Enable cpl_scalars export from ATM and NoahMP for use by CMEPS #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* using ac5520fa CMEPS and 6048f89c FV3, 3 hafs tests fail because cpl.hi file is not identical. Can't check w/o cprnc rt_hafs_regional_atm_ocn_intel.log:9: Comparing ufs.hafs.cpl.hi.2019-08-29-21600.nc .....USING NCCMP......NOT IDENTICAL rt_hafs_regional_docn_intel.log:7: Comparing ufs.hafs.cpl.hi.2019-08-29-21600.nc .....USING NCCMP......NOT IDENTICAL rt_hafs_regional_docn_oisst_intel.log:7: Comparing ufs.hafs.cpl.hi.2019-08-29-21600.nc .....USING NCCMP......NOT IDENTICAL hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel show differences in all files. ?need to check swnext in current ufs.configure
* ran develop branch w/ cmeps and fv3 branch separately and all baselines passed
* use feature branch for noahmp adding cpl_scalars
DeniseWorthen
changed the title
14 tasks
|
@jkbk2004 If I am going to test this, then I should test it one last time against Rocky8 on Hera (since Hera is still our only GNU platform). Why is the update to Rocky8 not the priority PR for today? Only 4 nodes are still unmigrated, which means anyone working w/ UWM on Hera is sharing just those 4 nodes. |
We run GNU tests on Hercules. |
|
I agree. #2194 is high priority. |
|
We do not run coupled tests for GNU on Hercules. |
I see, do you remember why we skip coupled tests on Hercules? |
|
@DusanJovic-NOAA We are waiting for an FMS update in SS1.6 I believe. |
|
@DeniseWorthen I wonder about the timeline for this PR. The actual land fix is depends on it. Thanks. |
|
@uturuncoglu Yes. I've been in a holding pattern after the Hera/Rocky8 transition because we lost GNU testing capability for some of the coupled tests on Hera and we are waiting for stack/1.6 in order to get back our GNU functionality on Hercules. I don't like not being able to fully test w/ GNU. I was hoping the Hera/R8 issues would be resolved quickly but at this point, I am going to proceed w/ the final testing w/o fully testing GNU. Hopefully we can get it committed next week. Thanks. |
|
@FernandoAndrade-NOAA It should be good to go. Let me know if you spot any issues. |
|
Looks good to go from my side, @zach1221 @BrianCurtis-NOAA FYI starting testing for this PR. |
|
Two tests timed out on Hera, rerunning with increased time limit. |
|
Derecho is still not up, so I think we'll push the Hera logs here soon and skip for this PR. Then catch up the baselines in the next. |
|
Hera log pushed up alongside a time limit increase for the two failing tests. |
|
Ok, @DeniseWorthen fv3atm is merged now as well. |
jkbk2004
approved these changes
Apr 3, 2024
BrianCurtis-NOAA
approved these changes
Apr 3, 2024
zhanglikate
added a commit
to zhanglikate/ufs-weather-model
that referenced
this pull request
May 3, 2024
commit f234a3e Author: Ufuk Turunçoğlu <[email protected]> Date: Tue Apr 30 11:35:25 2024 -0600 Fix for land component model (ufs-community#2191) * UFSWM - fix fully coupled land component configuration * NOAHMP - get fixed information from surface file commit 04bbc15 Author: jiandewang <[email protected]> Date: Thu Apr 25 14:52:00 2024 -0400 update MOM6 to its main repo. 20240401 commit (ufs-community#2241) * UFSWM - * MOM6 - update MOM6 to its main repo. 20240401 commit (NCAR-candidate-20240319) commit b6c576d Author: Daniel Sarmiento <[email protected]> Date: Tue Apr 23 12:24:22 2024 -0400 Merged global namelist (ufs-community#2173) * UFSWM - global_control.nml_IN has been added as the new regression test namelist template for all global regression tests. The namelist now uses pointers (i.e. @[abc]) for variables and default values have been added to the default_vars.sh script. A new section in default_vars.sh has been added (export_tiled) to account for tiled RTs that pulls the correct parameter files using the ATMRES variable. Regression tests have been modified to account for these changes. Tests that were not compatible with the GFSv17_p8 core have been disabled for now. They will be turned on as they are updated from GFSv16 to GFSv17. commit 5d2ca19 Author: WenMeng-NOAA <[email protected]> Date: Fri Apr 19 13:59:12 2024 -0400 Update upp submodule (ufs-community#2213) * UFSWM - Update inline post * FV3 - Update upp submodule for inline post commit 47c0099 Author: Brian Curtis <[email protected]> Date: Wed Apr 17 15:59:48 2024 -0400 Add bash linting to CI. Cleanup .sh scripts a bit. Address .sh bugs. Adds -v Verbose option. (ufs-community#2218) Remove nowarn Intel compiler flag (ufs-community#2225) * UFSWM - Add bash linting to CI: - uses superlinter to check for consistent bash code writing - Cleans up .sh scripts to comply with superlinter - Cleans up .sh scripts to be more consistent, easier to read. - Add's -v verbose option if debugging outputs needed, otherwise simplifies rt.sh run echo's. - Addresses smaller bugs - quota/timeout search logic adjusted. - check for dirs existing (DISKNM, STMP, PTMP) before starting. - adjustments/cleanup to ecflow/rocoto sections - rt.sh will attempt to start ecflow, and only stop ecflow if it started from rt.sh. - fix for issue where run_dir will not delete properly. * FV3: Address compiler warnings * atmos_cubed_sphere: Address compiler warnings. commit 4f32a4b Author: Rick Grubin <[email protected]> Date: Mon Apr 15 07:21:08 2024 -0600 Document ATMW / ATMAERO / HAFS WM configurations (ufs-community#2160) * UFSWM * doc/Userguide * source * conf.py * Configurations.rst * FAQ.rst * InputsOutputs.rst * Introduction.rst commit ac4445d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 15 08:59:42 2024 -0400 Bump idna from 3.6 to 3.7 in /doc/UsersGuide (ufs-community#2234) *doc/UserGuide *requirements.txt - updates inda version from 3.6 to 3.7 commit 281b32f Author: Samuel Trahan (NOAA contractor) <[email protected]> Date: Mon Apr 15 08:38:01 2024 -0400 bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (ufs-community#2201) * UFSWM - None. * FV3 - Write component will use kchunk3d. Model init sends the right tile number to CCPP. * atmos_cubed_sphere - Initialize the hailwat variable. Pass global_tile index to model. commit 8a5f711 Author: Denise Worthen <[email protected]> Date: Thu Apr 11 13:32:26 2024 -0400 Add PIO namelist control for CICE (ufs-community#2145) Update to CICE-Consortium/CICE aca8357. Adds implementation of namelist PIO options for CICE commit 45c8b2a Author: JONG KIM <[email protected]> Date: Thu Apr 4 19:49:13 2024 -0400 Hotfix/cubed sphere hash fix: HAILCAST diagnostic code (units issue) (ufs-community#2223) cubed_sphere hash update: f060e85 for a bug- fix in the HAILCAST diagnostic code (units issue) commit 26e6db6 Author: Denise Worthen <[email protected]> Date: Wed Apr 3 19:57:08 2024 -0400 Enable cpl_scalars export from ATM and NoahMP for use by CMEPS (ufs-community#2175) * CMEPS - allow additional dimension in cpl_scalars for CSG and regional ATM domains for use in mediator history files * CMEPS - fix mapping mask for lnd->atm * FV3 - add export of cpl_scalars * NOAHMP - add export of cpl_scalars commit 1411b90 Author: Dusan Jovic <[email protected]> Date: Mon Apr 1 18:04:44 2024 -0400 Update module_write_netcdf to avoid hangs in RRFS runs (ufs-community#2193) * UFSWM - Update module_write_netcdf to avoid hangs in RRFS runs * FV3 - Update module_write_netcdf to avoid hangs in RRFS runs commit 87c27b9 Author: Matthew Masarik <[email protected]> Date: Fri Mar 29 15:23:42 2024 -0400 WW3 feature: Langmuir turbulence parameterization (ufs-community#2195) * WW3 - Langmuir turbulence parameterization commit c54e986 Author: Samuel Trahan (NOAA contractor) <[email protected]> Date: Wed Mar 27 16:11:03 2024 -0400 regression test system bug fixes, eliminate MOM6 warnings (ufs-community#2197), add xr_cnvcld flag to FV3 (ufs-community#2185) (ufs-community#2202) * UFSWM - atparse.bash: correctly handle input that doesn't end with an end-of-line character. Fix some bugs in Rocoto support and clean up rt.sh. * FV3 - namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite * ccpp - physics-level changes to implement new namelist variable * MOM6 - update MOM6 code to eliminate all compiler warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
The following tests change baselines because the format of the mediator history file which is compared changes (the fields are now on the regional tile instead of the mesh). All other files in these tests are B4B
The control_p8_atmlnd_intel fails comparison because of a change in the mapping masks. This bug was found during extensive testing of the NoahMP PR (see NOAA-EMC/noahmp#8 (comment))
Input data Changes:
Library Changes/Upgrades:
Testing Log: