Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to spack-stack-1.5.0 (update to gocart hash f7b34e) #1920

Merged
merged 60 commits into from
Oct 30, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 25, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This is the first PR of two or three, which updates only a few packages (scotch, ip, w3emc).

One or two additional PRs will update fms to 2023.02 and esmf/mapl to 8.5.0/2.40.3 after this PR is merged.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

none created

Subcomponent Pull Requests

Blocking Dependencies

n/a

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

I don't know, EPIC will have to help me testing across platforms

  • No changes are expected to any regression test.
  • Changes are expected to the following tests (from a comparison run against the existing baseline - note that only coupled tests change results, as expected):

Libraries

  • Not Needed
  • Needed - but all installed on the platforms currently using spack-stack
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@climbfuji climbfuji changed the title NEEDS HELP FROM EPIC WITH TESTING: Update to spack-stack-1.5.0 NOT YET READY (NEEDS HELP FROM EPIC WITH TESTING: Update to spack-stack-1.5.0) Sep 25, 2023
@climbfuji climbfuji changed the title NOT YET READY (NEEDS HELP FROM EPIC WITH TESTING: Update to spack-stack-1.5.0) NEEDS HELP FROM EPIC WITH TESTING: Update to spack-stack-1.5.0 Sep 26, 2023
@climbfuji climbfuji marked this pull request as ready for review September 27, 2023 13:41
@climbfuji climbfuji requested a review from jkbk2004 September 27, 2023 13:41
@climbfuji
Copy link
Collaborator Author

@jkbk2004 Would you be so kind to add the necessary reviewers for this PR and help me with the process? Thanks!

@climbfuji climbfuji changed the title NEEDS HELP FROM EPIC WITH TESTING: Update to spack-stack-1.5.0 NEEDS HELP FROM EPIC WITH TESTING: Update to spack-stack-1.5.0, includes #1922 (update to gocart hash f7b34e) Sep 27, 2023
@mathomp4
Copy link

@climbfuji Virginie has merged in GEOS-ESM/GOCART#254 and your changes (and those from @bbakernoaa GEOS-ESM/GOCART#253) are now in GOCART develop at hash GEOS-ESM/GOCART@0414229

@climbfuji climbfuji self-assigned this Sep 27, 2023
@climbfuji
Copy link
Collaborator Author

Thanks @mathomp4, that was quick! I updated the submodule pointer in this PR.

@jkbk2004
Copy link
Collaborator

Apologies missed this comment on Friday. The WW3 PR was merged, we talked about reverting, but at this point it was just left in as it would likely be merged with this PR soon. @MatthewMasarik-NOAA and @jkbk2004 worked out the details offline - perhaps they can comment more. Let me know what we need to do.

@BrianCurtis-NOAA The use of @JessicaMeixner-NOAA WW3 feature branch in this PR is ok even though it was already merged on WW3 repo. When this PR get merged, we can simply point to the correct hash. Note that there is no impact on the result from the WW3 bug fix as well.

@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed Baseline Updates Current baselines will be updated. labels Oct 30, 2023
@DusanJovic-NOAA
Copy link
Collaborator

@climbfuji This PR does not include #1922 anymore. The PR title should be updated.

@zach1221 zach1221 changed the title Update to spack-stack-1.5.0, includes #1922 (update to gocart hash f7b34e) Update to spack-stack-1.5.0 (update to gocart hash f7b34e) Oct 30, 2023
@BrianCurtis-NOAA
Copy link
Collaborator

That "WCOSS2" log was actually Acorn.

@zach1221
Copy link
Collaborator

@climbfuji Regression testing is complete. Can you please review the 7 open conversations to see if they can be resolved? Also please ensure the WW3 hash is pointing to the latest. I think @JessicaMeixner-NOAA's recent PR#1112 is still the correct one. NOAA-EMC/WW3@02693d8

@JessicaMeixner-NOAA
Copy link
Collaborator

@climbfuji Regression testing is complete. Can you please review the 7 open conversations to see if they can be resolved? Also please ensure the WW3 hash is pointing to the latest. I think @JessicaMeixner-NOAA's recent PR#1112 is still the correct one. NOAA-EMC/WW3@02693d8

Correct

@climbfuji
Copy link
Collaborator Author

I reverted the .gitmodules change and updated the submodule pointer for WW3. The contents of the WW3 directory were identical before/after updating to NOAA-EMC/WW3@02693d8. There's only one comment from @DusanJovic-NOAA that we need to resolve, other then that it's all good to go.

@zach1221
Copy link
Collaborator

zach1221 commented Oct 30, 2023

@JessicaMeixner-NOAA @MatthewMasarik-NOAA feel free to add your reviews here as well.

@JessicaMeixner-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA is in a meeting and can approve as well when he's done if both approvals are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.