Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of CCPP timestep_init and timestep_final phases #338

Closed
climbfuji opened this issue Dec 18, 2020 · 0 comments · Fixed by #337
Closed

Implementation of CCPP timestep_init and timestep_final phases #338

climbfuji opened this issue Dec 18, 2020 · 0 comments · Fixed by #337
Assignees
Labels
enhancement New feature or request

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Dec 18, 2020

Description

Add CCPP timestep_init and timestep_final phases to ufs-weather-model, fv3atm, GFDL_atmos_cubed_sphere, ccpp-framework, ccpp-physics.

The timestep_init phase will take the place of and run the time_vary group of the CCPP suite definition files, i.e. run at the beginning of every time step. The timestep_final phase will be added at the end of the physics calls at every time step (not doing anything at the moment).

Same as for the CCPP init and final phases, timestep_init and timestep_final will automatically run over all blocks at the same time (same as the time_vary group), and the conversion of the blocked data into contiguous arrays and back happens in the auto-generated caps (instead of manually inside the time_vary physics). This allows us to remove the dependency on the GFS DDTs in the calls to the time_vary physics. It also simplifies greatly the calls to gcycle/sfcsub.

No changes required for the suite definition files or the regression test configuration.

Because the data conversions happen in different places, and the loops over the individual blocks inside the time_vary physics is removed, it is possible that this will change the answer in full/prod mode. In debug or repro mode, b4b identical results are expected. This will need to be confirmed when it is time for committing the PRs listed below.

Solution

The implementation of these changes requires five PRs across the different repositories:

#337
NOAA-EMC/fv3atm#217
NCAR/ccpp-physics#534
NCAR/ccpp-framework#344
NOAA-EMC/GFDL_atmos_cubed_sphere#47

Alternatives

None.

Related to

See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant