Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COMINgfs from workflow #735

Closed
gsketefian opened this issue Apr 8, 2022 · 5 comments
Closed

Remove COMINgfs from workflow #735

gsketefian opened this issue Apr 8, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@gsketefian
Copy link
Collaborator

gsketefian commented Apr 8, 2022

Description

PR #713 has changed the tests so that in NCO mode, COMINgfs (TEST_COMINgfs in the machine files) is no longer used in the workflow. Also, USE_USER_STAGED_EXTRN_FILES is now used instead

Solution

Remove COMINgfs from workflow (?).

@gsketefian gsketefian added the enhancement New feature or request label Apr 8, 2022
@mkavulich mkavulich self-assigned this Apr 8, 2022
@gsketefian
Copy link
Collaborator Author

@chan-hoo Do you really want to get rid of COMINgfs from the workflow? The directory TEST_COMINgfs in machine/hera.sh is not used at all:

TEST_COMINgfs="/scratch2/NCEPDEV/fv3-cam/noscrub/UFS_SRW_App/COMGFS"

@mkavulich FYI.

@chan-hoo
Copy link
Collaborator

chan-hoo commented Apr 8, 2022

@gsketefian, I've never talked about "COMINgfs" before. The "COMINgfs" should not be removed from the workflow. It should be renamed to "COMIN" though. I'll open a PR for the vertical structure of the "nco" mode later.

@gsketefian
Copy link
Collaborator Author

@chan-hoo In that case, all the nco tests need to be using COMINgfs (or just COMIN). USE_USER_STAGED_EXTRN_FILES should not be set in the NCO tests; it should be left to its default value of "FALSE".

@chan-hoo
Copy link
Collaborator

chan-hoo commented Apr 8, 2022

@gsketefian, I understand what your point is now. The vertical structure of the 'nco' mode should be updated. I just started working on it, so it will take some time. Until the vertical structure is set up correctly, I think we'll need to use USE_USER_STAGED_EXTRN_FILES. I think the 'nco' mode is not relevant to this release. I agree with you. It should be modified eventually. If this is not an urgent issue, please give me some time.

@chan-hoo
Copy link
Collaborator

@gsketefian, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants