-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove COMINgfs from workflow #735
Comments
@chan-hoo Do you really want to get rid of
@mkavulich FYI. |
@gsketefian, I've never talked about "COMINgfs" before. The "COMINgfs" should not be removed from the workflow. It should be renamed to "COMIN" though. I'll open a PR for the vertical structure of the "nco" mode later. |
@chan-hoo In that case, all the nco tests need to be using |
@gsketefian, I understand what your point is now. The vertical structure of the 'nco' mode should be updated. I just started working on it, so it will take some time. Until the vertical structure is set up correctly, I think we'll need to use |
@gsketefian, I'll close this issue. |
Description
PR #713 has changed the tests so that in NCO mode,
COMINgfs
(TEST_COMINgfs
in the machine files) is no longer used in the workflow. Also,USE_USER_STAGED_EXTRN_FILES
is now used insteadSolution
Remove
COMINgfs
from workflow (?).The text was updated successfully, but these errors were encountered: