Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eliminate need for hasStyles configuration option #4395

Open
techfg opened this issue Jan 3, 2025 · 0 comments
Open

chore: eliminate need for hasStyles configuration option #4395

techfg opened this issue Jan 3, 2025 · 0 comments

Comments

@techfg
Copy link
Collaborator

techfg commented Jan 3, 2025

Currently, to ensure that custom CSS is packed in a bundle, the hasStyles configuration must be set to true in the bundle.yaml. This has two shortcomings:

  1. It's not documented anywhere
  2. There should be ways to determine if a runtime.css is present dynamically and include rather than requiring the config option.

I believe rumtime.css should only be present after build if custom css is imported in which case its intended to be used. Assuming that is the case, the option/flag should be able to be removed. At minimum, the config option should be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant