Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hook to configure OAuth2 client because function Poison.decode!/1 is undefined #50

Closed
mildred opened this issue Jul 26, 2019 · 1 comment · Fixed by #51
Closed
Assignees

Comments

@mildred
Copy link

mildred commented Jul 26, 2019

The issue has already been reported in #43. basically, the OAuth2 lib no longer depends on Poison as the JSON backend is now configurable. The only problem is that there is no hook to provide access to the OAuth2 client object to configure the JSON backend.

Would it be possible to provide such a hook?

perhaps updating the README to tell how it should be used might be nice too.

@taj taj self-assigned this Jul 29, 2019
@taj
Copy link
Member

taj commented Jul 29, 2019

this is something similar to what we did in the ueberauth_google lib (ueberauth/ueberauth_google#58)

I'll try to get it done shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants