Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Application landing page after login configuration has a hardcoded path. #448

Open
tindunken opened this issue Jun 23, 2021 · 2 comments · May be fixed by #493
Open

[BUG] Application landing page after login configuration has a hardcoded path. #448

tindunken opened this issue Jun 23, 2021 · 2 comments · May be fixed by #493
Assignees
Labels
needs-investigation Needs further investigation type: bug Something isn't working

Comments

@tindunken
Copy link

Hi Dan,

The "application landing page after login" configuration has a hardcoded path for the UDP apps. As a result, it caused a 404 error on the redirect after authenticated.

@noinarisak
Copy link
Contributor

Thanks @tindunken for submitting an Issue.

Can you give us example of what the url that you want to redirect to? I look at the following code block https://github.com/udplabs/zartan/blob/master/app.py#L217-L239. It looks like there a couple areas the landing page can be set. 1. by app_post_login_landing_url or APP_POST_LOGIN_LANDING_URL environment variable or 2. from_uri query string.

In UDP, you can set the APP_POST_LOGIN_LANDING_URL but I think you tried that aready? correct?

@tindunken
Copy link
Author

Initially I wanted it to redirect to another UDP demo, something like the dealer demo that has the userapp page. However, upon reviewing it with Dan, it looks like the path /hospitality was hard coded in the redirect so it was automatically appending it to any URL that you add to the APP_POST_LOGIN_LANDING_URL. If we remove the hard coded path then I think it should work.

@noinarisak noinarisak changed the title Application landing page after login configuration has a hardcoded path. [BUG] Application landing page after login configuration has a hardcoded path. Oct 7, 2021
@noinarisak noinarisak added the needs-investigation Needs further investigation label Nov 3, 2021
@mdwallick mdwallick self-assigned this Feb 3, 2022
@mdwallick mdwallick added the type: bug Something isn't working label Feb 3, 2022
@mdwallick mdwallick linked a pull request Feb 3, 2022 that will close this issue
@mdwallick mdwallick removed a link to a pull request Feb 3, 2022
@mdwallick mdwallick linked a pull request Feb 3, 2022 that will close this issue
@mdwallick mdwallick removed a link to a pull request Feb 7, 2022
@mdwallick mdwallick linked a pull request Feb 7, 2022 that will close this issue
@noinarisak noinarisak linked a pull request Mar 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation Needs further investigation type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants