Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last plan label across the top of the charts like Split Monitor mistakenly shows Free #67

Open
ian-cameron opened this issue Aug 9, 2019 · 0 comments

Comments

@ian-cameron
Copy link
Contributor

The last coordination plan label in the series shows up as free, and this results in incorrect max out and force off calculations because max outs are calculated for free periods and force offs are calculated for coordinated periods. This is on Purdue phase termination and split failure charts too.
For example:

SplitMonitor

We did some debugging and found that code used for the charts looks for Event Code 131 (coord pattern change) at the end of the analysis period. I'll send in a PR, but if we add a dummy Event 131 at the end of the analysis period, this fixed several charts where the last coordination plan was missing:

FixedSplitMonitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant