Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P-184] Cannot toggle marks (bold etc) in Firefox, for a word selected by double clicking #1987

Closed
mz8i opened this issue Nov 12, 2022 · 3 comments · Fixed by ianstormtaylor/slate#5275
Labels
bug Something isn't working firefox linear Sync GitHub Issue from community members...

Comments

@mz8i
Copy link

mz8i commented Nov 12, 2022

Description

Just evaluating Plate and I stumbled upon a rather problematic issue using Firefox. This actually occurs in the official examples.

In the Balloon Toolbar, when you double click a word to select and toggle bold on it, then later it's not possible to toggle bold on the word if you double-click it again.

Steps

  • go to https://platejs.org
  • double click any word to select it
  • click B in the balloon toolbar to toggle bold on the whole word
  • click away to deselect the word / put the cursor anywhere else
  • double click the same word again
  • PROBLEM: the bold indicator in the tooltip is not highlighted. Clicking it (any number of times) doesn't change the state of the editor in any way.

Notes:

  • it works as you'd expect in Chrome
  • in Firefox, you can toggle bold later on but only if you drag-select the word

Expectation

You can select a word by double clicking, toggle a mark (like bold, italic etc) on it, then move away, and then when you double click the word again, the bold status should be correctly shown and it should be possible to toggle it off again.
Dragging to select requires more precision than double clicking, and therefore is much slower - so it's not acceptable for this to be the required action.

Environment

  • browser: Firefox (v106.0.5, on Manjaro Linux)

Thanks for looking into this! I'm keen to use the framework but this is a major obstacle given the UX degradation for Firefox users.

P-184

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@mz8i mz8i added the bug Something isn't working label Nov 12, 2022
@dylans
Copy link
Collaborator

dylans commented Nov 12, 2022

This is definitely a regression as it used to work as you would expect. I can confirm it's an issue (and not an OS related quirk).

@O4epegb
Copy link
Collaborator

O4epegb commented Nov 21, 2022

Can confirm too, happens only in Firefox on macos too

@mmourafiq
Copy link
Contributor

probably related to #1897

@zbeyens zbeyens added the linear Sync GitHub Issue from community members... label Jan 25, 2023
@zbeyens zbeyens changed the title Cannot toggle marks (bold etc) in Firefox, for a word selected by double clicking [P-184] Cannot toggle marks (bold etc) in Firefox, for a word selected by double clicking Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox linear Sync GitHub Issue from community members...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants