Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xng-breadcrumb inside ngIf needs a special check since router events are already finished #97

Merged
merged 3 commits into from
Nov 14, 2021
Merged

fix: xng-breadcrumb inside ngIf needs a special check since router events are already finished #97

merged 3 commits into from
Nov 14, 2021

Conversation

udayvunnam
Copy link
Owner

What is this PR about

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows the guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

@github-actions
Copy link

Hello 👋 @udayvunnam
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@udayvunnam udayvunnam merged commit c7ce2d0 into main Nov 14, 2021
@udayvunnam udayvunnam deleted the fix/breadcrumb-inside-ngIf branch November 14, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when xng-breadcrumb is wrapped with an ngIf (to know device resolution), its seems to get an empty route
1 participant
@udayvunnam