Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should be able to specify breadcrumb alias without @ prefix #48

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

udayvunnam
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows the guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

We don't need user to specify {breadcrumb: { alias: '@id' } }
we just need {breadcrumb: { alias: 'id' } } with breadcrumbService.set('@id', 'MapingLabel').

Adding a test to verify this.

Issue Number: fixes #47

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@udayvunnam udayvunnam changed the title fix: alias has to be specified without @ prefix fix: should be able to specify breadcrumb alias without @ prefix Sep 8, 2020
@udayvunnam udayvunnam merged commit c29f4d4 into master Sep 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/alias-prefix branch September 8, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alias is not not working
1 participant