Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs are shown by default, even if there is no breadcrumbs specified for a path. Make this behaviour optional. #2

Closed
udayvunnam opened this issue Jul 6, 2019 · 2 comments
Closed

Breadcrumbs are shown by default, even if there is no breadcrumbs specified for a path. Make this behaviour optional. #2

udayvunnam opened this issue Jul 6, 2019 · 2 comments
Assignees
@udayvunnam
Labels
good first issue Good for newcomers

Comments

@udayvunnam
Copy link
Owner

Is your feature request related to a problem? Please describe.
Breadcrumbs will be shown by default event if there is no breadcrumbs specified for a path. User have to explicitely define not to show breadcrumbs as per the comment - #1 (comment)

Describe the solution you'd like
Make this behaviour optional. Provide a boolean flag that can turn this behaviour off

Describe alternatives you've considered
It might be possible that part of application needs the above default behaviour and other part of routes may not need this behaviour. tackle this problem

Additional context
This will not break any existing behaviour, just adds additional behaviour.
@udayvunnam udayvunnam self-assigned this Jul 6, 2019
@udayvunnam udayvunnam added enhancement New feature or request good first issue Good for newcomers labels Jul 6, 2019
@udayvunnam udayvunnam changed the title Breadcrumbs will be shown by default event if there is no breadcrumbs specified for a path. Make this behaviour optional Breadcrumbs are shown by default, even if there is no breadcrumbs specified for a path. Make this behaviour optional. Jul 6, 2019
@udayvunnam
Copy link
Owner Author

Fixes - #1 (comment)

@udayvunnam
Copy link
Owner Author

udayvunnam commented Jul 17, 2019 •
edited
Loading

Disabling default mapping of route to breadcrumb label:
To avoid breadcrumb labels showing by default even for routes that don't have breadcrumb configuration set defaultMapping=false.

<xng-breadcrumb [defaultMapping]="false"></xng-breadcrumb>

released with version 1.2.0

@udayvunnam udayvunnam pinned this issue Jul 17, 2019
@udayvunnam udayvunnam removed the enhancement New feature or request label Jul 20, 2019
@udayvunnam udayvunnam unpinned this issue Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@udayvunnam udayvunnam

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@udayvunnam