Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accessibility): removed aria-role from the separator #141

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

kapenzo
Copy link
Contributor

@kapenzo kapenzo commented Jun 20, 2022

The JAWS Screen Reader has a problem with the element containing both - arial-hidden="true"
and role="separator".

Resolves #140

What is this PR about

The JAWS Screen Reader has a problem with the element containing both - arial-hidden="true"
and role="separator". To solve this issue the property role="separator" has been deleted.

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows the guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

The JAWS Screen Reader has a problem with the element containing both - arial-hidden="true"
and role="separator".

Resolves udayvunnam#140
@kapenzo kapenzo requested a review from udayvunnam as a code owner June 20, 2022 14:37
@kapenzo
Copy link
Contributor Author

kapenzo commented Jun 20, 2022

No tests and docs needed I think...

@udayvunnam udayvunnam merged commit 9b2589f into udayvunnam:main Jun 20, 2022
@udayvunnam
Copy link
Owner

@all-contributors please add @kapenzo for Code

@allcontributors
Copy link
Contributor

@udayvunnam

I've put up a pull request to add @kapenzo! 🎉

This was referenced Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility on breadcrumb's separator
2 participants