Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect angular guard checks and do not navigate if authGuard check returns false #114

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

udayvunnam
Copy link
Owner

What is this PR about

respect angular guard checks and do not navigate if authGuard check returns false

fixes #113 and #111

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows the guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Hello 👋 @udayvunnam
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@udayvunnam udayvunnam merged commit 48f4772 into main Jan 3, 2022
@udayvunnam udayvunnam deleted the canDeactivate-gaurd-check branch January 3, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breadcrumbs improper handling with CanDeactivate guard check
1 participant