From f11980ece279a215a8b2d702c90f6a1e1acd54a0 Mon Sep 17 00:00:00 2001
From: Uday Vunnam <uday4vunnam@gmail.com>
Date: Tue, 5 Nov 2019 22:58:19 +0530
Subject: [PATCH] feat:  custom separator icon, custom template and i18n
 BREAKING CHANGE: Modified API for component and service.

---
 .../xng-breadcrumb/src/lib/auto-label.pipe.ts | 15 ++++
 .../src/lib/breadcrumb.component.html         |  6 +-
 .../src/lib/breadcrumb.component.ts           | 14 +++-
 .../src/lib/breadcrumb.module.ts              |  3 +-
 .../src/lib/breadcrumb.service.ts             | 74 +++++++++++--------
 projects/xng-breadcrumb/src/lib/breadcrumb.ts |  5 ++
 6 files changed, 77 insertions(+), 40 deletions(-)
 create mode 100644 projects/xng-breadcrumb/src/lib/auto-label.pipe.ts

diff --git a/projects/xng-breadcrumb/src/lib/auto-label.pipe.ts b/projects/xng-breadcrumb/src/lib/auto-label.pipe.ts
new file mode 100644
index 0000000..b3cfbe0
--- /dev/null
+++ b/projects/xng-breadcrumb/src/lib/auto-label.pipe.ts
@@ -0,0 +1,15 @@
+import { Pipe, PipeTransform } from '@angular/core';
+
+@Pipe({
+  name: 'autoLabel'
+})
+export class AutoLabelPipe implements PipeTransform {
+  transform(breadcrumbList: any, shouldautoGenerate: boolean, ...args: any[]): any {
+    if (shouldautoGenerate) {
+      return breadcrumbList;
+    } else {
+      return breadcrumbList.filter(breadcrumb => !breadcrumb.isAutoGeneratedLabel);
+    }
+    return null;
+  }
+}
diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.component.html b/projects/xng-breadcrumb/src/lib/breadcrumb.component.html
index 4bc589b..4b4d5a2 100644
--- a/projects/xng-breadcrumb/src/lib/breadcrumb.component.html
+++ b/projects/xng-breadcrumb/src/lib/breadcrumb.component.html
@@ -1,6 +1,6 @@
-<nav aria-label="breadcrumb" class="xng-breadcrumb-root">
+<nav aria-label="breadcrumb" class="xng-breadcrumb-root" [ngClass]="class">
   <ol class="xng-breadcrumb-list">
-    <ng-container *ngFor="let breadcrumb of breadcrumbs$ | async; last as isLast; first as isFirst">
+    <ng-container *ngFor="let breadcrumb of breadcrumbs$ | async | autoLabel: autoGenerate; last as isLast; first as isFirst">
       <li class="xng-breadcrumb-item">
         <a *ngIf="!isLast" [routerLink]="[breadcrumb.routeLink]" class="xng-breadcrumb-link">
           <ng-container
@@ -17,7 +17,7 @@
         </label>
       </li>
 
-      <li class="xng-breadcrumb-separator" aria-hidden="true" role="separator" *ngIf="!isLast">
+      <li *ngIf="!isLast" class="xng-breadcrumb-separator" aria-hidden="true" role="separator">
         <ng-container *ngTemplateOutlet="separatorTemplate"></ng-container>
         <ng-container *ngIf="!separatorTemplate">{{ separator }}</ng-container>
       </li>
diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.component.ts b/projects/xng-breadcrumb/src/lib/breadcrumb.component.ts
index 735ae04..d7a3eaa 100644
--- a/projects/xng-breadcrumb/src/lib/breadcrumb.component.ts
+++ b/projects/xng-breadcrumb/src/lib/breadcrumb.component.ts
@@ -1,4 +1,4 @@
-import { Component, ContentChild, Input, OnInit, TemplateRef } from '@angular/core';
+import { Component, ContentChild, Input, OnInit, TemplateRef, ViewEncapsulation } from '@angular/core';
 import { Observable } from 'rxjs';
 import { BreadcrumbItemDirective } from './breadcrumb-item.directive';
 import { BreadcrumbService } from './breadcrumb.service';
@@ -7,7 +7,8 @@ import { Breadcrumb } from './breadcrumb';
 @Component({
   selector: 'xng-breadcrumb',
   templateUrl: './breadcrumb.component.html',
-  styleUrls: ['./breadcrumb.component.scss']
+  styleUrls: ['./breadcrumb.component.scss'],
+  encapsulation: ViewEncapsulation.None
 })
 export class BreadcrumbComponent implements OnInit {
   breadcrumbs$: Observable<Breadcrumb[]>;
@@ -28,7 +29,13 @@ export class BreadcrumbComponent implements OnInit {
    * If true, breacrumb is auto generated even without any mapping label
    * Default label is same as route segment
    */
-  @Input() defaultMapping = true;
+  @Input() autoGenerate = true;
+
+  /**
+   * custom class provided by consumer to increase specificity
+   * This will benefit to override styles that are conflicting
+   */
+  @Input() class = '';
 
   /**
    * separator between breadcrumbs, defaults to '/'.
@@ -56,7 +63,6 @@ export class BreadcrumbComponent implements OnInit {
   constructor(private breadcrumbService: BreadcrumbService) {}
 
   ngOnInit() {
-    this.breadcrumbService.defaultMapping = this.defaultMapping;
     this.breadcrumbs$ = this.breadcrumbService.breadcrumbs$;
   }
 }
diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.module.ts b/projects/xng-breadcrumb/src/lib/breadcrumb.module.ts
index 72dd053..ecded78 100644
--- a/projects/xng-breadcrumb/src/lib/breadcrumb.module.ts
+++ b/projects/xng-breadcrumb/src/lib/breadcrumb.module.ts
@@ -3,9 +3,10 @@ import { NgModule } from '@angular/core';
 import { RouterModule } from '@angular/router';
 import { BreadcrumbItemDirective } from './breadcrumb-item.directive';
 import { BreadcrumbComponent } from './breadcrumb.component';
+import { AutoLabelPipe } from './auto-label.pipe';
 
 @NgModule({
-  declarations: [BreadcrumbComponent, BreadcrumbItemDirective],
+  declarations: [BreadcrumbComponent, BreadcrumbItemDirective, AutoLabelPipe],
   imports: [CommonModule, RouterModule],
   exports: [BreadcrumbComponent, BreadcrumbItemDirective]
 })
diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.service.ts b/projects/xng-breadcrumb/src/lib/breadcrumb.service.ts
index 8c3129e..0212eba 100644
--- a/projects/xng-breadcrumb/src/lib/breadcrumb.service.ts
+++ b/projects/xng-breadcrumb/src/lib/breadcrumb.service.ts
@@ -40,12 +40,6 @@ export class BreadcrumbService {
   private pathParamRegexIdentifier = '/:[^/]+';
   private pathParamRegexReplacer = '/[^/]+';
 
-  /**
-   * If true, breacrumb is auto generated even without any mapping label
-   * Default label is same as route segment
-   */
-  public defaultMapping = true;
-
   constructor(private activatedRoute: ActivatedRoute, private router: Router) {
     this.setBaseBreadcrumb();
     this.detectRouteChanges();
@@ -87,14 +81,21 @@ export class BreadcrumbService {
   private setBaseBreadcrumb() {
     const baseConfig = this.router.config.find(pathConfig => pathConfig.path === '');
     if (baseConfig && baseConfig.data) {
-      const { label, alias, skip = false, info } = this.getBreadcrumbOptions(baseConfig.data);
+      let { label, alias, skip = false, info } = this.getBreadcrumbOptions(baseConfig.data);
+
+      let isAutoGeneratedLabel = false;
+      if (typeof label !== 'string' && !label) {
+        label = '';
+        isAutoGeneratedLabel = true;
+      }
 
       this.baseBreadcrumb = {
         label,
         alias,
         skip,
         info,
-        routeLink: this.baseHref
+        routeLink: this.baseHref,
+        isAutoGeneratedLabel
       };
     }
   }
@@ -126,7 +127,8 @@ export class BreadcrumbService {
       return this.prepareBreadcrumbList(activatedRoute.firstChild, routeLinkPrefix);
     }
     // remove breadcrumb items that needs to be hidden or don't have a label
-    const breacrumbsToShow = this.currentBreadcrumbs.filter(breadcrumb => !breadcrumb.skip);
+    const breacrumbsToShow = this.currentBreadcrumbs.filter(item => !item.skip);
+
     this.breadcrumbs.next(breacrumbsToShow);
   }
 
@@ -138,12 +140,14 @@ export class BreadcrumbService {
     const routeLink = `${routeLinkPrefix}${resolvedPath}`;
 
     let { label, alias, skip, info } = this.getFromStore(breadcrumb.alias, routeLink);
+    let isAutoGeneratedLabel = false;
 
     if (typeof label !== 'string') {
       if (typeof breadcrumb.label === 'string') {
         label = breadcrumb.label;
-      } else if (this.defaultMapping) {
+      } else {
         label = resolvedPath;
+        isAutoGeneratedLabel = true;
       }
     }
 
@@ -152,7 +156,8 @@ export class BreadcrumbService {
       alias: alias || breadcrumb.alias,
       skip: skip || breadcrumb.skip,
       info: info || breadcrumb.info,
-      routeLink
+      routeLink,
+      isAutoGeneratedLabel
     };
   }
 
@@ -220,39 +225,44 @@ export class BreadcrumbService {
    * Update current breadcrumb definition and emit a new stream of breadcrumbs
    * Also update the store to reuse dynamic declarations
    */
-  private updateStore(spec) {
-    const { alias, routeLink, routeRegex, ...rest } = spec;
-
-    let breadcrumbItemIndex;
-    let storeItemIndex;
-
-    // identify macthing breadcrumb and store item
-    if (alias) {
-      breadcrumbItemIndex = this.currentBreadcrumbs.findIndex(item => alias === item.alias);
-      storeItemIndex = this.dynamicBreadcrumbStore.findIndex(item => alias === item.alias);
-    } else if (routeLink) {
-      breadcrumbItemIndex = this.currentBreadcrumbs.findIndex(item => routeLink === item.routeLink);
-      storeItemIndex = this.dynamicBreadcrumbStore.findIndex(item => routeLink === item.routeLink);
-    } else if (routeRegex) {
-      breadcrumbItemIndex = this.currentBreadcrumbs.findIndex(item => new RegExp(routeRegex).test(item.routeLink + '/'));
-      storeItemIndex = this.dynamicBreadcrumbStore.findIndex(item => routeRegex === item.routeRegex);
-    }
+  private updateStore(breadcrumb) {
+    const { breadcrumbItemIndex, storeItemIndex } = this.getBreadcrumbIndexes(breadcrumb);
 
     // if breadcrumb is present in current breadcrumbs update it and emit new stream
     if (breadcrumbItemIndex > -1) {
-      this.currentBreadcrumbs[breadcrumbItemIndex] = { ...this.currentBreadcrumbs[breadcrumbItemIndex], ...rest };
-      const breacrumbsToShow = this.currentBreadcrumbs.filter(breadcrumb => !breadcrumb.skip);
+      this.currentBreadcrumbs[breadcrumbItemIndex] = { ...this.currentBreadcrumbs[breadcrumbItemIndex], ...breadcrumb };
+      const breacrumbsToShow = this.currentBreadcrumbs.filter(item => !item.skip);
       this.breadcrumbs.next([...breacrumbsToShow]);
     }
 
     // If the store already has this route definition update it, else add
     if (storeItemIndex > -1) {
-      this.dynamicBreadcrumbStore[storeItemIndex] = { ...this.dynamicBreadcrumbStore[storeItemIndex], ...rest };
+      this.dynamicBreadcrumbStore[storeItemIndex] = { ...this.dynamicBreadcrumbStore[storeItemIndex], ...breadcrumb };
     } else {
-      this.dynamicBreadcrumbStore.push({ alias, routeLink, routeRegex, ...rest });
+      this.dynamicBreadcrumbStore.push(breadcrumb);
     }
   }
 
+  private getBreadcrumbIndexes(breadcrumb): any {
+    const { alias, routeLink, routeRegex } = breadcrumb;
+    let indexMap = {};
+    // identify macthing breadcrumb and store item
+    if (alias) {
+      indexMap = this.getBreadcrumbIndexesByType('alias', alias);
+    } else if (routeLink) {
+      indexMap = this.getBreadcrumbIndexesByType('routeLink', routeLink);
+    } else if (routeRegex) {
+      indexMap = this.getBreadcrumbIndexesByType('routeRegex', routeRegex);
+    }
+    return indexMap;
+  }
+
+  private getBreadcrumbIndexesByType(key: string, value: string) {
+    const breadcrumbItemIndex = this.currentBreadcrumbs.findIndex(item => value === item[key]);
+    const storeItemIndex = this.dynamicBreadcrumbStore.findIndex(item => value === item[key]);
+    return { breadcrumbItemIndex, storeItemIndex };
+  }
+
   private resolvePathParam(path: string, activatedRoute: ActivatedRoute) {
     // if the path segment is a route param, read the param value from url
     if (path.startsWith(this.pathParamPrefix)) {
diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.ts b/projects/xng-breadcrumb/src/lib/breadcrumb.ts
index 6008f17..309081d 100644
--- a/projects/xng-breadcrumb/src/lib/breadcrumb.ts
+++ b/projects/xng-breadcrumb/src/lib/breadcrumb.ts
@@ -27,4 +27,9 @@ export interface Breadcrumb {
    * path '/mentor/:id' becomes routeRegex '/mentor/[^/]+', which can be matched against when needed
    */
   routeRegex?: string;
+  /**
+   * isAutoGeneratedLabel has to be present at component level but not at the service,
+   * since we may need to support multiple breadcrumb components in same app
+   */
+  isAutoGeneratedLabel?: boolean;
 }