New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omega should be a keyword argument #2

Open

alexdenker opened this issue Jul 12, 2024 · 0 comments

alexdenker commented Jul 12, 2024

Regarding: https://github.com/ucl-bug/lbs/blob/6203890e73394b981730504c788f0c6c152dc732/bno/datasets.py#L163C1-L163C71

omega should be a keyword argument, i.e., change to
sim_params = helmholtz.default_params(src, medium, omega=self.omega)

alexdenker changed the title ~~omega should~~ omega should be a keyword argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment