Make DspComplex multiplies use growing addition. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DspComplex relies on using the underlying Ring's multiplication. For UInt, SInt, FixedPoint, etc. these additions wrap instead of grow. For our implementation of complex multiplication, growing is more desirable than wrapping. This commit adds specialized versions of the DspComplex for UInt, SInt, FixedPoint, etc. that use growing addition.
|
Fine by me. It would be nice if Firrtl could throw a warning when the
output of some chain of multiplications grew to have too many bits (sanity
check in case people generated waste fully large intermediate terms)
…On Wednesday, April 24, 2019, Paul Rigge ***@***.***> wrote:
DspComplex relies on using the underlying Ring's multiplication. For UInt,
SInt, FixedPoint, etc. these additions wrap instead of grow. For our
implementation of complex multiplication, growing is more desirable
than wrapping.
This commit adds specialized versions of the DspComplex for UInt, SInt,
FixedPoint, etc. that use growing addition.
This is in response to an issue @mkosunen <https://github.com/mkosunen>
and @Yuedai14 <https://github.com/Yuedai14> were running into that they
were working around by increasing input bitwidth.
@shunshou <https://github.com/shunshou>, what do you think?
------------------------------
You can view, comment on, or merge this pull request online at:
#157
Commit Summary
- Make DspComplex multiplies use growing addition.
File Changes
- *M* src/main/scala/dsptools/numbers/chisel_types/
DspComplexTypeClass.scala
<https://github.com/ucb-bar/dsptools/pull/157/files#diff-0> (40)
- *M* src/test/scala/dsptools/numbers/DspComplexSpec.scala
<https://github.com/ucb-bar/dsptools/pull/157/files#diff-1> (4)
Patch Links:
- https://github.com/ucb-bar/dsptools/pull/157.patch
- https://github.com/ucb-bar/dsptools/pull/157.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#157>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABSNGFQ35CDBCXMNEFY2AILPSD6IZANCNFSM4HII5NQA>
.
|
|
Hm actually my recommendation was always to use context_(op) and have
people explicitly define behavior.
…On Wed, Apr 24, 2019 at 11:22 PM Angie ***@***.***> wrote:
Fine by me. It would be nice if Firrtl could throw a warning when the
output of some chain of multiplications grew to have too many bits (sanity
check in case people generated waste fully large intermediate terms)
On Wednesday, April 24, 2019, Paul Rigge ***@***.***> wrote:
> DspComplex relies on using the underlying Ring's multiplication. For
> UInt, SInt, FixedPoint, etc. these additions wrap instead of grow. For our
> implementation of complex multiplication, growing is more desirable
> than wrapping.
>
> This commit adds specialized versions of the DspComplex for UInt, SInt,
> FixedPoint, etc. that use growing addition.
>
> This is in response to an issue @mkosunen <https://github.com/mkosunen>
> and @Yuedai14 <https://github.com/Yuedai14> were running into that they
> were working around by increasing input bitwidth.
>
> @shunshou <https://github.com/shunshou>, what do you think?
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #157
> Commit Summary
>
> - Make DspComplex multiplies use growing addition.
>
> File Changes
>
> - *M*
> src/main/scala/dsptools/numbers/chisel_types/DspComplexTypeClass.scala
> <https://github.com/ucb-bar/dsptools/pull/157/files#diff-0> (40)
> - *M* src/test/scala/dsptools/numbers/DspComplexSpec.scala
> <https://github.com/ucb-bar/dsptools/pull/157/files#diff-1> (4)
>
> Patch Links:
>
> - https://github.com/ucb-bar/dsptools/pull/157.patch
> - https://github.com/ucb-bar/dsptools/pull/157.diff
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#157>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABSNGFQ35CDBCXMNEFY2AILPSD6IZANCNFSM4HII5NQA>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DspComplex relies on using the underlying Ring's multiplication. For UInt, SInt, FixedPoint, etc. these additions wrap instead of grow. For our implementation of complex multiplication, growing is more desirable
than wrapping.
This commit adds specialized versions of the DspComplex for UInt, SInt, FixedPoint, etc. that use growing addition.
This is in response to an issue @mkosunen and @Yuedai14 were running into that they were working around by increasing input bitwidth.
@shunshou, what do you think?