Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock and Reset IOCells #823

Closed
KPrabs106 opened this issue Mar 11, 2021 · 2 comments
Closed

Clock and Reset IOCells #823

KPrabs106 opened this issue Mar 11, 2021 · 2 comments
Labels

Comments

@KPrabs106
Copy link
Contributor

Impact: rtl

Tell us about your environment:
Chipyard Version: 1.4.0

What is the current behavior?
IO Cells generated for clock and reset do not use IOCellKey, resulting in GenericDigitalInIOCell

What is the expected behavior?
Clock and reset IO cell generation should be using IOCellKey

Other information

I might have misunderstood how to use IOCellKey, but I think the following changes are needed:

val (reset_io, resetIOCell) = IOCell.generateIOFromSignal(async_reset_wire, "reset",

should be
val (reset_io, resetIOCell) = IOCell.generateIOFromSignal(async_reset_wire, "reset", p(IOCellKey),
and

val (clock_io, clockIOCell) = IOCell.generateIOFromSignal(clock_wire, "clock")

should be
val (clock_io, clockIOCell) = IOCell.generateIOFromSignal(clock_wire, "clock", p(IOCellKey))

@KPrabs106 KPrabs106 added the bug label Mar 11, 2021
@jerryz123
Copy link
Contributor

Thanks for catching this. Can you open a PR against dev to fix it?

@jerryz123
Copy link
Contributor

Fixed, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants