We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact: rtl
Tell us about your environment: Chipyard Version: 1.4.0
What is the current behavior? IO Cells generated for clock and reset do not use IOCellKey, resulting in GenericDigitalInIOCell
What is the expected behavior? Clock and reset IO cell generation should be using IOCellKey
Other information
I might have misunderstood how to use IOCellKey, but I think the following changes are needed:
chipyard/generators/chipyard/src/main/scala/Clocks.scala
Line 28 in e3d23f1
should be val (reset_io, resetIOCell) = IOCell.generateIOFromSignal(async_reset_wire, "reset", p(IOCellKey), and
val (reset_io, resetIOCell) = IOCell.generateIOFromSignal(async_reset_wire, "reset", p(IOCellKey),
Line 97 in e3d23f1
val (clock_io, clockIOCell) = IOCell.generateIOFromSignal(clock_wire, "clock", p(IOCellKey))
The text was updated successfully, but these errors were encountered:
Thanks for catching this. Can you open a PR against dev to fix it?
Sorry, something went wrong.
Fixed, thanks for the PR
No branches or pull requests
Impact: rtl
Tell us about your environment:
Chipyard Version: 1.4.0
What is the current behavior?
IO Cells generated for clock and reset do not use IOCellKey, resulting in GenericDigitalInIOCell
What is the expected behavior?
Clock and reset IO cell generation should be using IOCellKey
Other information
I might have misunderstood how to use IOCellKey, but I think the following changes are needed:
chipyard/generators/chipyard/src/main/scala/Clocks.scala
Line 28 in e3d23f1
should be
val (reset_io, resetIOCell) = IOCell.generateIOFromSignal(async_reset_wire, "reset", p(IOCellKey),
and
chipyard/generators/chipyard/src/main/scala/Clocks.scala
Line 97 in e3d23f1
should be
val (clock_io, clockIOCell) = IOCell.generateIOFromSignal(clock_wire, "clock", p(IOCellKey))
The text was updated successfully, but these errors were encountered: