-
Notifications
You must be signed in to change notification settings - Fork 22
Issue: #399 Update mod.rs, quickfix workaround #400
base: main
Are you sure you want to change the base?
Conversation
allow podman to run with --userns=keep-id
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 83.23% 83.10% -0.13%
==========================================
Files 36 36
Lines 2964 2983 +19
Branches 279 288 +9
==========================================
+ Hits 2467 2479 +12
- Misses 377 382 +5
- Partials 120 122 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johne8: thanks for looking at this and help at figuring out your issue with podman!
I don’t really like that we hardcode the ownership integer value of nobody, which can vary depending on the distribution and user config.
Secondly, this check is to ensure an integrity of the database and poking a hole there doesn’t seem like the right solution. I think looking at the user namespace mapping might help there to ensure that in the parent namespace, the uid/gid still match the expecations, wdyt?
hmm, I'm not too familiar with namespaces. The best thing I can think of currently is reading the values of: /proc/sys/kernel/overflowuid and /proc/sys/kernel/overflowgid, then check if the uid and gid owner matches that. |
526edd1
to
96b6cdb
Compare
96b6cdb
to
941b339
Compare
Have you checked out my latest commit? It seems to work fine :) Also in Ubuntu 22.04 LTS, it seems like UID/GID above 2147483647 (SignedInt) causes issues in gnome. So needed to add some workaround for this also by reducing the UID of the users that have a UID calculated above that value. |
Workaround for issue #399
allow podman to run with --userns=keep-id