Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide console only if it's dedicated to the launcher process #184

Merged
merged 12 commits into from
May 3, 2022
Merged

Hide console only if it's dedicated to the launcher process #184

merged 12 commits into from
May 3, 2022

Commits on May 2, 2022

  1. CLI for store/start menu launch in appxmanifest.

    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    1ee5031 View commit details
    Browse the repository at this point in the history

  2. Created a new CLI option --from-start-menu-or-store 

    Meant for Start Menu / Microsoft Store only.
    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c88f146 View commit details
    Browse the repository at this point in the history

  3. Deals with new CLI: --from-start-menu-or-store 

    Application reacts to that option with:
interactive install + autodetect GUI support + hide console

Combined with other options results in either nothing or invalid options
It is meant for Store / Start menu launches, as the name suggests.
Applied by its own on an already registered distro means nothing.
Undocumented for that reason.
    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    8b69c5b View commit details
    Browse the repository at this point in the history

  4. Prevents console staying hidden after splash quits 

    Now if splash gets closed by the user before its time, the console
could get stuck hidden because
this function tries to place it behind a window that doesn't exist.
    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    2b85e51 View commit details
    Browse the repository at this point in the history

  5. Tests documenting combinations with the new CLI option

    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    cd61617 View commit details
    Browse the repository at this point in the history

  6. Rollback to --hide-console

    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    7700078 View commit details
    Browse the repository at this point in the history

  7. Revert MyDistro.appxmanifest overrides 

    Instead, we take advantage of the existing empty extended_messages.h files.
Those files override the in-source tree to avoid leaking the new behavior into the old releases.
Now they explicitly defines preprocessor constants that are evaluated to decide parsing the new command lines or just excluding them.
    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    90cca9b View commit details
    Browse the repository at this point in the history

  8. Fixes formatting warning 

    Avoids clang-format bounce between different formatting styles

For this specific declaration.  It doesn't have many knobs for adjusting template instantiation.
    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    cc806b9 View commit details
    Browse the repository at this point in the history

  9. Ensures upstream-delegated cases won't be warn 

    help for instance, would otherwise cause a warning.
    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    572ca16 View commit details
    Browse the repository at this point in the history

  10. Fixes the Copyright year

    @CarlosNihelton
    CarlosNihelton committed May 2, 2022
    Configuration menu
    Copy the full SHA
    403c920 View commit details
    Browse the repository at this point in the history

  11. Refreshes releases and assets

    @CarlosNihelton
    CarlosNihelton authored May 2, 2022
    Configuration menu
    Copy the full SHA
    23e2076 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #195 from ubuntu/auto-update-releases-hide-console-if 

    Refresh releases and assets
    @CarlosNihelton
    CarlosNihelton authored May 2, 2022
    Configuration menu
    Copy the full SHA
    218e6e7 View commit details
    Browse the repository at this point in the history