Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sltt-app): change port number for compressor (to not conflict with older installs) #4

Open
3 tasks
ericpyle opened this issue Apr 29, 2024 · 0 comments
Labels

Comments

@ericpyle
Copy link
Collaborator

ericpyle commented Apr 29, 2024

[Possible new approach: use contextBridge (window.electronApi) to provide an alternate api so that the backend can talk "directly" with ffmpeg without using an express server. See discussion here https://signlanguaget-nfl9249.slack.com/archives/C05GD89Q13K/p1718242466793769]
 
Although users who simply use latest version of sltt-app should not encounter this error, it could happen if they also try to launch their old compressor installation that's also set to port 29678. So it's probably best to configure a different compressor port for sltt-app so it won't conflict even if they launch that one. It will also help reduce confusion of state issue if they are using the web app and sltt-app and performing compressor functions in both.

Suggestions:
In compressor\src\config.js

  • configure sltt-app compressor port at 29679 (i.e. 29678 + 1)
  • configure new /resources temp folder path (e.g. %TEMP%/sltt-app/compression-server/resources/ffmpeg-x64.exe) separate from sltt pwa temp folder (%TEMP%/compression-server/resources/ffmpeg-x64.exe) to allow for separate ffmpeg upgrade
  • configure new /videos temp folder based on a directory associated with the browser window that is using it (e.g. %TEMP%/sltt-app/compression-server/window-{id}/videos/ffmpeg-x64.exe) separate from sltt pwa temp folder (%TEMP%/compression-server/videos) to allow for multiple windows to do separate ffmpeg video functions

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant