feat: use negativo17 in lieu of rpmfusion #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experiment to see what the negativo17 fedora-multimedia repo can provide without rpmfusion.
|
As of the initial commit, I've done enough local testing to thing that this reasonably replaces rpmfusion with corresponding packages, except we do lose the |
|
If we build this in a backport for F40/F39 in our staging COPR we can move this forward. https://packages.fedoraproject.org/pkgs/ffmpegthumbnailer/ffmpegthumbnailer/ |
|
This issue is blocked by: ublue-os/packages#32 |
this blocking issue, re: ffmpegthumbnailer, has been closed and the package has been restored to package list in this PR. |
|
I think this is looking pretty good now. I've run builds locally and inspected the changed packages (eg, libheif, ffmpeg, pipewire bluetooth, libva and intel drivers, etc) to make sure the new packages provide what was there before... instead of some things being added/swapped in |
…apped before but makes sense given the context
dosubot
bot
added
size:M
|
You have |
KyleGospo
approved these changes
Oct 5, 2024
m2Giles
approved these changes
Oct 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
TL;DR the gstreamer-plugin change should have been from this PR. This comment captures the changes so it can be well understood. Longer version... It resulted in larger package diffs than I had expected, so I'm documenting them here for reference. I built custom images from the following build configs:
Changes when rebasing from sb-main-40 rpmfusion to sb-main-40 negativo17: Changes when rebasing from sb-main-40 negativo17 to sb-main-40 negativo17-gstreamer: |
|
That looks like a ton of linear algebra libraries. |
bsherman
added a commit
that referenced
this pull request
Oct 6, 2024
In PR #636 I was over-eager in changing out "-free" packages which had alternatives in negativo17's fedora-multimedia repo. Specifically, the gstreamer-plugins provided have a large set of dependencies which increase the size of the "*-main" images by approximately 1GiB. Reverting that change as if a user or downstream wishes it, they can make the change (eg, Bazzite does this I think), but others should not be burdened with this size change, expecially not as part of a PR which was just supposed to swap out the source of some packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our uses of the rpmfusion package repo with negativo17's fedora-multimedia repo.
The two motivations for this:
I've run builds locally and inspected the changed packages (eg, libheif, ffmpeg, gstreamer1-plugins, pipewire bluetooth, libva and intel drivers, etc) to make sure the new packages provide what was there before.. Instead of some package names being replaced in
packages.jsonthey are now "override-replaced" in theinstall.sh. Also, some package name changes are due to negativo17's conventions or that their packages have more files in a single package vs fedora (eg, libheif from negativo17 has the contents of the both libheif and libheif tools from before).