fix: github release install silently fails if no urls found #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
@bcook254 I just stumbled onto this PR as it never seemed to cross my radar before. Appreciate the simple solution, as the author of this script, I've run into the problem myself and hadn't fixed it yet. |
castrojo
approved these changes
Nov 17, 2024
bsherman
approved these changes
Nov 17, 2024
bsherman
added a commit
to ublue-os/ucore
that referenced
this pull request
Nov 17, 2024
This copies the fix from ublue-os/main#571 to ensure that the github release install script fails properly when nothing matches the filter. The bug fixed by this also relates to #214 since that kind of bug report will be caught by build failures in the future, thanks to this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this script for my own personal build and found that if the script does not find any valid rpms it will silently continue. This change creates an array and simply selects the first url (as the current script does). If there are no urls then
rpm-ostree installshould fail.