Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package request: tumbler #55

Closed
mitchejj opened this issue Mar 7, 2023 · 5 comments · Fixed by #56
Closed

package request: tumbler #55

mitchejj opened this issue Mar 7, 2023 · 5 comments · Fixed by #56

Comments

@mitchejj
Copy link

mitchejj commented Mar 7, 2023 •
edited
Loading

Describe the package

The default file manager in Sericea is Thunar which requires tumbler and not ffmpegthumbnailer (#49) I would also suggest excluding ffmpegthumbnailer for Sericea builds.

xfce:thunar:4.16:tumbler [Xfce Docs]
Arch Linux - thunar 4.18.4-1 (x86_64)

Image

Sericea
@mitchejj mitchejj changed the title tumbler (thumbnail support of Thunar request: tumbler Mar 7, 2023
@mitchejj mitchejj changed the title request: tumbler package request: tumbler Mar 7, 2023
@castrojo
Copy link
Member

castrojo commented Mar 7, 2023

Ok so same as with Kinoite, we need to move ffpmegthumbnailer to each flavor, I'll try to get this today but if you want to send a PR feel free!

@ribbanya
Copy link

ribbanya commented Mar 7, 2023

Can these kinds of things be abstracted somehow, maybe into just tasks? Like, main can say "I need a thumbnail provider" and then the flavor can provide it further down?

@castrojo
Copy link
Member

castrojo commented Mar 7, 2023

The packages.json is designed so we can do any combo of packages for any desktop just for this purpose. Things in the justfiles would be after image creation.

@castrojo castrojo mentioned this issue Mar 7, 2023
Merged
@castrojo castrojo reopened this Mar 7, 2023
@castrojo
Copy link
Member

castrojo commented Mar 7, 2023

Just reopening this, if you could confirm that it's working as expected in the latest image and close this that'd be awesome. Thanks for the feedback!

@mitchejj
Copy link
Author

mitchejj commented Mar 7, 2023

Works.

@castrojo castrojo closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add tumbler for thumbnails on sericea ublue-os/main
3 participants
@mitchejj @castrojo @ribbanya