-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build nvidia images in main repo #319
Conversation
This adds the nvidia build scripts to the repo and reconfigures Containerfile to build both a main and nvidia image per provided build-args. Workflow is also adapted with a matrix to support this use case. "main" build and post-install scripts renamed to make things more consistent and easier to follow for future dev. COPY used instead of ADD in Containerfile for best practice compliance.
After merging, we must disable actions on the https://github.com/ublue-os/nvidia/ repo, and probably post a message to the README and/or archive the repo. |
iirc archiving the repo will turn off the actions in one step. |
Yes but do we want a message on the readme or no? |
Yeah, a signpost would help, I can work on that. You keep going on this. |
I already added I think this is ready as soon as y'all approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Unrelated)
It might be a good idea to bundle these Nvidia install and post-install scripts into the akmods image instead of requiring downstream consumers to copy, paste and keep them maintained.
We can keep them up-to-date in the akmods repo, then if people are consuming the akmods repo rather than main images, they have the scripts bundled with the image to call.
Send the horse. Full attack.
This adds the nvidia build scripts to the repo and reconfigures
Containerfile
to build bothFOO-main
andFOO-nvidia
images per matrix provided build-args. Workflow matrix was modified to support this use case, including changes to variables and tag generation.Reviewers: please double-check the generated tags look correct per image. I did review and put some effort into this, but would appreciate extra eyes.
Changes which were not technically required:
build.sh
,post-install.sh
,packages.json
renamed (withmain-
prefix) to make things more consistent and easier to follow for futureContainerfile
for compliance with best practicesgithub-release-install.sh
to avoid some observed intermittent errors