Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable fedora 39 builds #301

Merged
merged 10 commits into from
Sep 19, 2023
Merged

feat: enable fedora 39 builds #301

merged 10 commits into from
Sep 19, 2023

Conversation

p5
Copy link
Member

@p5 p5 commented Aug 13, 2023

A bit of an experiment to see how much needs changing for us to start building against Fedora 39.
The images are now being pushed to Quay (or at least for silverblue).

@p5 p5 changed the title feature: enable fedora 39 builds feat: enable fedora 39 builds Aug 13, 2023
@yodatak
Copy link

yodatak commented Sep 7, 2023

Interedted because it could be easy to debug n+1 fedora

@EyeCantCU EyeCantCU force-pushed the enable-fedora-39-builds branch from 88b8059 to 55fa9c3 Compare September 19, 2023 13:36
@EyeCantCU EyeCantCU force-pushed the enable-fedora-39-builds branch from 55fa9c3 to 2a042b4 Compare September 19, 2023 13:50
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@p5 p5 marked this pull request as ready for review September 19, 2023 15:22
@p5 p5 requested a review from castrojo as a code owner September 19, 2023 15:22
- major_version: 38
is_latest_version: true
is_stable_version: true
is_gts_version: true
- major_version: 39
is_latest_version: true
Copy link
Member Author

@p5 p5 Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember the decision - are we marking beta releases as the latest?

I seem to think we wanted latest to be the latest stable release, then ":stable" to be a few weeks late - once we've tested stuff?
I know it's confusing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest and stable are required to push to the latest tag so the latest stable release is what gets pushed there. 39 won't get pushed to that until it is marked as stable. When that happens, we set the flag for latest and stable releases to false for 38 but keep gts true and that will be the release that stays behind. Setting the latest flag here for 39 won't have an impact on our tags as it isn't marked stable yet. I know that sounds confusing too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy for this to be merged then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's get this rolled out :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work y'all!!

@EyeCantCU EyeCantCU added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 67d4669 Sep 19, 2023
58 checks passed
@EyeCantCU EyeCantCU deleted the enable-fedora-39-builds branch September 19, 2023 16:27
@szescxz
Copy link

szescxz commented Nov 9, 2023

@EyeCantCU
While I only tested on Bazzite, I believe google-noto-sans-cjk-fonts is still needed on F39 builds.
More info here: ublue-os/bazzite#153 (comment)

@KyleGospo
Copy link
Member

KyleGospo commented Nov 9, 2023

Original fix is restored on Bazzite F39

@EyeCantCU
Copy link
Member

@EyeCantCU
While I only tested on Bazzite, I believe google-noto-sans-cjk-fonts is still needed on F39 builds.
More info here: ublue-os/bazzite#153 (comment)

Thank you for letting me know! I'll see about getting it restored in main momentarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants