Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to just includes. #48

Closed
xynydev opened this issue May 20, 2023 · 2 comments
Closed

Migrate to just includes. #48

xynydev opened this issue May 20, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@xynydev
Copy link
Member

xynydev commented May 20, 2023

I just closed the issue #27 on startingpoint and am moving it now here.

just seems to be very slow in updating currently. I have a tested solution, though.

Aliasing alias just='just --unstable' works (mostly) perfectly and just does not nag about it.
The only problem is that the default recipe in main.just errors out.

default:
   @just --list

This can be easily fixed by adding the --unstable flag to the command.

These are the two changes I'm proposing;

  • Replace the entirety of ublue-os-just.sh with alias just='just --unstable'
  • Make the default recipe in main.just
    default:
        @just --unstable --list

Furthermore, instruct users to create a ~/.justfile with the following contents (maybe with a cat EOF command to make it extra easy).

!include /usr/share/ublue-os/just/main.just
!include /usr/share/ublue-os/just/nvidia.just
# only enable when using a custom image
# !include /usr/share/ublue-os/just/custom.just

The current system is functional, but still feels more of a hack compared to this. I'm also positive the PR for just making it possible to use a environment variable to set the unstable mode won't be merged in a while, as the latest commit touching on the project's code is from January and development seems sluggish there. Not to even say about when the ìnclude directive would be made stable.

@castrojo castrojo added the help wanted Extra attention is needed label May 21, 2023
@castrojo
Copy link
Member

Oh nice catch! Yeah let's do this, I put a help wanted tag on it!

@xynydev
Copy link
Member Author

xynydev commented May 22, 2023

Sure, I'll probably PR this in today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants