feat: add dive command #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p5
approved these changes
Dec 30, 2023
Comment on lines
+142
to
145
| COPY --from=cgr.dev/chainguard/dive:latest /usr/bin/dive /usr/bin/dive | ||
| COPY --from=cgr.dev/chainguard/flux:latest /usr/bin/flux /usr/bin/flux | ||
| COPY --from=cgr.dev/chainguard/helm:latest /usr/bin/helm /usr/bin/helm | ||
| COPY --from=cgr.dev/chainguard/ko:latest /usr/bin/ko /usr/bin/ko |
There was a problem hiding this comment.
Since these are all single binaries, maybe we should start fetching them direct from GitHub Releases so we don't need to verify the signatures?
I don't think we're getting any benefits from pulling them from the Chainguard images?
There was a problem hiding this comment.
This part and the github action are kind of an SBOM demo I'm working on.
wizzywizard65
pushed a commit
to wizzywizard65/bluefin
that referenced
this pull request
Dec 31, 2023
awesomekyle
pushed a commit
to awesomekyle/bluefin
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/wagoodman/dive
This is useful for inspecting container sizes, etc but needs to be on the image.