Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make podman-machine work by default OOB #1861

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

tulilirockz
Copy link
Collaborator

@tulilirockz tulilirockz commented Oct 31, 2024

This just adds podman-machine support for Bluefin. This fixes #1825

@tulilirockz tulilirockz requested a review from castrojo as a code owner October 31, 2024 01:42
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Oct 31, 2024
@bsherman
Copy link
Contributor

bsherman commented Nov 1, 2024

Thank you for the issue and the PR!

Do you have any idea when this problem began?

@tulilirockz
Copy link
Collaborator Author

Thank you for the issue and the PR!

Do you have any idea when this problem began?

Honestly, no idea, podman machine never worked on my machine, I installed Bluefin-dx on F40, about 2 or 3 months ago and, on 40 it didnt work, now on 41 it also doesnt work (OOB i mean).

@p5
Copy link
Member

p5 commented Nov 2, 2024

FYI - this does bring in a bunch of dependencies for multi-arch

Added:
  SLOF-20220719-5.git6b6c16b4.fc41.noarch
  edk2-aarch64-20240813-2.fc41.noarch
  edk2-arm-20240813-2.fc41.noarch
  edk2-riscv64-20240813-2.fc41.noarch
  gvisor-tap-vsock-6:0.7.5-1.fc41.x86_64
  gvisor-tap-vsock-gvforwarder-6:0.7.5-1.fc41.x86_64
  openbios-1:20230126-4.gitaf97fd7.fc41.noarch
  podman-machine-5:5.2.5-1.fc41.x86_64
  qemu-2:9.1.1-1.fc41.x86_64
  qemu-system-aarch64-2:9.1.1-1.fc41.x86_64
  qemu-system-aarch64-core-2:9.1.1-1.fc41.x86_64
  qemu-system-alpha-2:9.1.1-1.fc41.x86_64
  qemu-system-alpha-core-2:9.1.1-1.fc41.x86_64
  qemu-system-arm-2:9.1.1-1.fc41.x86_64
  qemu-system-arm-core-2:9.1.1-1.fc41.x86_64
  qemu-system-avr-2:9.1.1-1.fc41.x86_64
  qemu-system-avr-core-2:9.1.1-1.fc41.x86_64
  qemu-system-cris-2:9.1.1-1.fc41.x86_64
  qemu-system-cris-core-2:9.1.1-1.fc41.x86_64
  qemu-system-loongarch64-2:9.1.1-1.fc41.x86_64
  qemu-system-loongarch64-core-2:9.1.1-1.fc41.x86_64
  qemu-system-m68k-2:9.1.1-1.fc41.x86_64
  qemu-system-m68k-core-2:9.1.1-1.fc41.x86_64
  qemu-system-microblaze-2:9.1.1-1.fc41.x86_64
  qemu-system-microblaze-core-2:9.1.1-1.fc41.x86_64
  qemu-system-mips-2:9.1.1-1.fc41.x86_64
  qemu-system-mips-core-2:9.1.1-1.fc41.x86_64
  qemu-system-or1k-2:9.1.1-1.fc41.x86_64
  qemu-system-or1k-core-2:9.1.1-1.fc41.x86_64
  qemu-system-ppc-2:9.1.1-1.fc41.x86_64
  qemu-system-ppc-core-2:9.1.1-1.fc41.x86_64
  qemu-system-riscv-2:9.1.1-1.fc41.x86_64
  qemu-system-riscv-core-2:9.1.1-1.fc41.x86_64
  qemu-system-rx-2:9.1.1-1.fc41.x86_64
  qemu-system-rx-core-2:9.1.1-1.fc41.x86_64
  qemu-system-s390x-2:9.1.1-1.fc41.x86_64
  qemu-system-s390x-core-2:9.1.1-1.fc41.x86_64
  qemu-system-sh4-2:9.1.1-1.fc41.x86_64
  qemu-system-sh4-core-2:9.1.1-1.fc41.x86_64
  qemu-system-sparc-2:9.1.1-1.fc41.x86_64
  qemu-system-sparc-core-2:9.1.1-1.fc41.x86_64
  qemu-system-tricore-2:9.1.1-1.fc41.x86_64
  qemu-system-tricore-core-2:9.1.1-1.fc41.x86_64
  qemu-system-xtensa-2:9.1.1-1.fc41.x86_64
  qemu-system-xtensa-core-2:9.1.1-1.fc41.x86_64
  qemu-tools-2:9.1.1-1.fc41.x86_64
  qemu-user-2:9.1.1-1.fc41.x86_64

Don't think this is an issue since podman-machine is quite important. Just something to be aware of.

@tulilirockz tulilirockz changed the title feat: add workaround to make podman-machine work by default OOB feat: make podman-machine work by default OOB Nov 2, 2024
@bsherman
Copy link
Contributor

bsherman commented Nov 2, 2024

FYI - this does bring in a bunch of dependencies for multi-arch

Don't think this is an issue since podman-machine is quite important. Just something to be aware of.

Hmm... good point @p5 I'd missed that in my testing since I already had those deps installed.

I 100% believe we want change in bluefin-dx ...

Given we have gcc in bluefin (non dx) I think it's hard to argue against podman-machine in bluefin, too.

I'm torn here... would want @castrojo and @m2Giles to weigh in.

@castrojo
Copy link
Member

castrojo commented Nov 2, 2024

I'm thinking -dx only.

gcc in normal bluefin is a known compromise we hate, so let's keep this in dx imo.

packages.json Outdated Show resolved Hide resolved
@tulilirockz tulilirockz force-pushed the podman-machine-oob branch 2 times, most recently from 3da2dd5 to 07c922e Compare November 2, 2024 19:09
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 2, 2024
@bsherman bsherman enabled auto-merge November 2, 2024 19:12
@bsherman bsherman disabled auto-merge November 2, 2024 19:41
@bsherman bsherman closed this Nov 2, 2024
@bsherman bsherman reopened this Nov 2, 2024
@bsherman bsherman merged commit daeb35e into ublue-os:main Nov 2, 2024
72 of 86 checks passed
@tulilirockz tulilirockz deleted the podman-machine-oob branch November 2, 2024 22:48
tulilirockz added a commit to tulilirockz/bluefin that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F41?: gvproxy not found when running podman machine
5 participants