Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made Documentation, Community and System Update icons themeable #1819

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Raindrac
Copy link
Collaborator

@Raindrac Raindrac commented Oct 21, 2024

This commit makes the Documentation, Community and System Update shortcuts customizable by icon themes. Pretty simple. I tested it on a virtual machine by both rebasing and updating, and I modified an icon theme so that it would change the appearance of these icons to confirm that they've been made themeable. Works just fine.

Resolves #1639.

@Raindrac Raindrac requested a review from castrojo as a code owner October 21, 2024 05:38
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Oct 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2024
@castrojo castrojo added this pull request to the merge queue Oct 21, 2024
@castrojo castrojo removed this pull request from the merge queue due to a manual request Oct 21, 2024
@castrojo castrojo added this pull request to the merge queue Oct 21, 2024
Merged via the queue into ublue-os:main with commit 342d01c Oct 21, 2024
49 of 64 checks passed
@Raindrac Raindrac deleted the themeableicons branch October 21, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation and System Update app icons can't be themed
2 participants