Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cryfs to bluefin #1771

Merged
merged 3 commits into from
Oct 12, 2024
Merged

feat: add cryfs to bluefin #1771

merged 3 commits into from
Oct 12, 2024

Conversation

Raindrac
Copy link
Collaborator

This commit makes io.github.mpobaschnig.Vaults functional. Although cryfs can be installed by the user through brew or a distrobox, Vaults won't detect it. It must be installed directly onto the system to be detected by Vaults. Of the four months I've used Bluefin, this is the only package I've been stuck with layering.

Why provide support for Vaults? KDE Plasma contains a built-in feature called vaults that allows for the creation of locally encrypted containers. This can offer a second layer of encryption beyond LUKS or allow you to create encrypted containers on an otherwise unencrypted file system. This feature was added in Plasma 5.11.

Vaults provides support for that feature on Gnome, helping bring feature parity between the two desktop environments.

This commit only adds cryfs to Bluefin because it's already included in KDE Plasma as a backend for its own vault feature. Yep, this means that Aurora already has it! No need to add it again.

This makes io.github.mpobaschnig.Vaults functional. Although cryfs can
be installed by the user through brew or a distrobox, Vaults won't
detect it. It must be installed directly onto the system to be detected
by Vaults. Of the four months I've used Bluefin, this is the only
package I've been stuck with layering.

Why provide support for Vaults? KDE Plasma contains a built-in feature
called vaults that allows for the creation of locally encrypted
containers. This can offer a second layer of encryption beyond LUKS or
allow you to create encrypted containers on an otherwise unencrypted
file system. This feature was added in Plasma 5.11.

Vaults provides support for that feature on Gnome, helping bring feature
parity between the two desktop environments.

This commit only adds cryfs to Bluefin because it's already included in
KDE Plasma as a backend for its own vault feature. Yep, this means that
Aurora already has it! No need to add it again.
@Raindrac Raindrac requested a review from castrojo as a code owner October 12, 2024 00:20
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Oct 12, 2024
@castrojo
Copy link
Member

Fine with this but please alphabetize it in the list, thanks!

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 12, 2024
@Raindrac
Copy link
Collaborator Author

There we go, done! Both the silverblue and kinoite sections were out of order, so I used Text Pieces to sort them both.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 12, 2024
@bsherman bsherman added this pull request to the merge queue Oct 12, 2024
@bsherman bsherman removed this pull request from the merge queue due to a manual request Oct 12, 2024
@bsherman bsherman enabled auto-merge (squash) October 12, 2024 03:25
@bsherman bsherman disabled auto-merge October 12, 2024 03:54
@bsherman bsherman added this pull request to the merge queue Oct 12, 2024
@bsherman bsherman removed this pull request from the merge queue due to the queue being cleared Oct 12, 2024
@castrojo castrojo added this pull request to the merge queue Oct 12, 2024
Merged via the queue into ublue-os:main with commit 9b78993 Oct 12, 2024
52 checks passed
@salim-b
Copy link
Contributor

salim-b commented Oct 17, 2024

@Raindrac I just tried to use the Vaults Flatpak with bluefin-dx:gts that seems to have picked up the cryfs addition:

❯ rpm -qa | grep cryfs
  1799:	cryfs-0.11.3-4.fc39.x86_64

But Vaults still says

No backends available. Please install gocryptfs or CryFS on your system.

Any idea what's going wrong?

@Raindrac
Copy link
Collaborator Author

@salim-b I managed to reproduce this by rebasing to bluefin:gts. It seems to only affect gts, not stable and latest, and so the bug will likely fix itself once Fedora updates to Fedora 40 in a couple weeks. Still, I might create an issue about this later.

Using cryfs in bluefin:gts outputs the following error:
cryfs: error while loading shared libraries: libfmt.so.10: cannot open shared object file: No such file or directory

So, something clearly went wrong with one of the libraries that it uses here. Not sure why yet. Gotta look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants