Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't update if on a metered connection #1658

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

castrojo
Copy link
Member

@castrojo castrojo commented Sep 9, 2024

No description provided.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Sep 9, 2024
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerblesh this ublue-update code looks great! I hadn't had a reason to look closely before.

This PR is good, because ublue-update will do the right thing.

https://github.com/ublue-os/ublue-update/blob/c420a9fc9116fda5ab0d9cc57cc41e0f2f68b850/src/ublue_update/update_inhibitors/hardware.py#L23

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 3, 2024
@castrojo castrojo merged commit 76fb411 into main Oct 3, 2024
34 of 42 checks passed
@castrojo castrojo deleted the castrojo-patch-4 branch October 3, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants