Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git-credential-libsecret to DX #1649

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

lethedata
Copy link
Contributor

Add git-credential-libsecret to allow storing git credentials in GNOME Keyring or KDE Wallet.

@lethedata lethedata requested a review from castrojo as a code owner September 5, 2024 06:08
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dx Developer Experience Image specific labels Sep 5, 2024
@m2Giles
Copy link
Member

m2Giles commented Sep 5, 2024

Please follow semantic naming. Otherwise this looks good.

@lethedata lethedata changed the title Add git-credential-libsecret to DX feat: add git-credential-libsecret to DX Sep 5, 2024
Add git-credential-libsecret to DX to allow storing git credentials in GNOME Keyring or KDE Wallet.
@lethedata lethedata force-pushed the git-credential-libsecret branch from 9d21ce3 to 8028f66 Compare September 5, 2024 14:33
@lethedata
Copy link
Contributor Author

lethedata commented Sep 5, 2024

Please follow semantic naming. Otherwise this looks good.

Sorry I'm not sure what you mean by that. I'm guessing it was the wrong commit message style I had (Semantic PR check).

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@m2Giles m2Giles enabled auto-merge September 5, 2024 19:42
@castrojo castrojo disabled auto-merge September 5, 2024 20:36
@castrojo castrojo merged commit 8c9b724 into ublue-os:main Sep 5, 2024
40 of 52 checks passed
@castrojo
Copy link
Member

castrojo commented Sep 5, 2024

Thanks!

@lethedata lethedata deleted the git-credential-libsecret branch September 5, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants