Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add breeze-gtk for aurora #1603

Closed
wants to merge 5 commits into from

Conversation

RealVishy
Copy link
Contributor

#1596

Adds breeze-gtk package for more native theming of gtk apps on KDE Plasma.

@RealVishy RealVishy requested a review from castrojo as a code owner August 14, 2024 02:18
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. aurora labels Aug 14, 2024
@castrojo
Copy link
Member

Why are we adding themes we're trying to get rid of them?

@RealVishy
Copy link
Contributor Author

RealVishy commented Aug 14, 2024

Why are we adding themes we're trying to get rid of them?

I wasn't aware themes were being removed. Tis helps improve the KDE experience with rpm provided gtk apps by making them look more in line with qt apps.

This theme already gets installed when GTK/libadwaita flatpaks are used.

https://github.com/flathub/org.gtk.Gtk3theme.Breeze

@castrojo castrojo closed this Aug 14, 2024
@castrojo castrojo reopened this Aug 14, 2024
@castrojo
Copy link
Member

(oops, misclicked, sorry), do we know why Kinoite doesn't ship this ootb?

@RealVishy
Copy link
Contributor Author

(oops, misclicked, sorry), do we know why Kinoite doesn't ship this ootb?

I couldn't find any info on if/why it's not in kinoite unfortunately. I do remember it definitely being installed in the fedora KDE spin though.

Here's the package info if it helps.
https://packages.fedoraproject.org/pkgs/breeze-gtk/breeze-gtk/

@RealVishy
Copy link
Contributor Author

image

@castrojo I created a vm of kinoite in gnome boxes and it shows that breeze-gtk is installed by default.

@m2Giles
Copy link
Member

m2Giles commented Sep 20, 2024

Let me check Aurora, but if this is in kinoite it should be in our image already.

It is already on image, so this pr shouldn't be needed.

Correction the literal breeze-gtk package isn't there, but its sub packages are there.

@RealVishy RealVishy closed this Sep 29, 2024
@RealVishy RealVishy deleted the vishy-package-add branch September 29, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants