Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ollama ujust script, some additions for removal verbs for the ollama and open-webui containers. #1588

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

muddyfeather
Copy link
Contributor

this is a first step on adding some actions to the ujust for ollama before potentially standardising this in bazzite too with another PR to bring "bazzite-tools.just" over. I've been using this, but i've seen others with the same opinion as me that i'd like to be able to mostly atomically clean up after it, as bazzite machines are often everything devices (so people are picky about things using their resources) I also can imagine a situation where in bazzite, people will want to tinker with this, but then remove and clear up afterwards because of the nature of the machine, and the users themselves are likely not as tech savvy as say aurora or bluefin people.
The script is a frankenstein now, but works in my test environment, backwards and forwards as necessary. I'm not sure what the established design conventions are for remove- verbs and how people expect it to work, but it's got an included "ollama help" to move things along.

I'm sure this will help dozens of people ;)

…some removal actions for added quadlets

refactoring the ollama ujust recipe, and adding in remove actions for both ollama and open-webui, still horribly broken, feels like whitespacing issue.
…e of open-webui

Fixed up now, tested on my machine at least, i'm sure there are dozens of us who'll use this!
@muddyfeather muddyfeather requested a review from castrojo as a code owner August 10, 2024 16:03
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Aug 10, 2024
@muddyfeather
Copy link
Contributor Author

FYI, happy to redo, if we prefer install-ollama, install-open-webui, remove-ollama recipes as a convention!

@muddyfeather muddyfeather changed the title Ollama ujust script, some additions for removal verbs for the ollama and open-webui containers. feat: ollama ujust script, some additions for removal verbs for the ollama and open-webui containers. Aug 11, 2024
@castrojo
Copy link
Member

I'm hoping we can get some testing on this, I'm short on time lately. :(

@castrojo castrojo merged commit d774ad7 into ublue-os:main Aug 14, 2024
52 checks passed
@castrojo
Copy link
Member

The weekly builds just passed so let's just get this into latest. Thanks for helping with this!

@muddyfeather
Copy link
Contributor Author

No problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants