Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update search-light default appearance #1256

Merged
merged 1 commit into from
May 5, 2024

Conversation

p5
Copy link
Member

@p5 p5 commented May 5, 2024

I found the default search light a little hard to read in some scenarios, so this PR darkens the background, rounds the edges to look more gnome-like and adds a very thin border.

Unfortunately blur was moved to the testing package since it caused a few bugs, so we are unable to use that.

Updates Search Light's default appearance from:
image

To:
image

@p5 p5 marked this pull request as ready for review May 5, 2024 22:25
@p5 p5 requested a review from castrojo as a code owner May 5, 2024 22:25
@p5 p5 requested review from noelmiller and m2Giles May 5, 2024 22:30
@p5 p5 enabled auto-merge May 5, 2024 22:48
@p5 p5 disabled auto-merge May 5, 2024 22:48
@p5 p5 merged commit 47bbaab into main May 5, 2024
34 checks passed
@p5 p5 deleted the update-searchlight-default-appearance branch May 5, 2024 22:48
@storopoli
Copy link
Contributor

storopoli commented May 7, 2024

In bluefin-dx-nvidia:gts I am getting:

TypeError: background is null

image

Shall I open an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants